You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "asl3 (via GitHub)" <gi...@apache.org> on 2023/07/31 22:56:25 UTC
[GitHub] [spark] asl3 opened a new pull request, #42251: [SPARK-44617] Support comparison between lists of Rows
asl3 opened a new pull request, #42251:
URL: https://github.com/apache/spark/pull/42251
### What changes were proposed in this pull request?
This PR adds support for the util `assertDataFrameEqual` argument `actual` to be of type list of Rows, to allow for comparison between two lists of Rows.
### Why are the changes needed?
The change is needed to allow for equality comparison between two lists of Rows, e.g. assertDataFrameEqual(df1.collect(), df2.collect())
### Does this PR introduce _any_ user-facing change?
Yes, this PR affects the user-facing util function `assertDataFrameEqual`.
### How was this patch tested?
Added tests to `python/pyspark/sql/tests/test_utils.py` and `python/pyspark/sql/tests/connect/test_utils.py`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #42251: [SPARK-44617] Support comparison between lists of Rows
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #42251:
URL: https://github.com/apache/spark/pull/42251#issuecomment-1659365763
Merged to master and branch-3.5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #42251: [SPARK-44617] Support comparison between lists of Rows
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #42251: [SPARK-44617] Support comparison between lists of Rows
URL: https://github.com/apache/spark/pull/42251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org