You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@seata.apache.org by "l81893521 (via GitHub)" <gi...@apache.org> on 2023/12/22 15:18:35 UTC

[PR] [WIP]Test: increase spring autoconfigure module unit test coverage [incubator-seata]

l81893521 opened a new pull request, #6198:
URL: https://github.com/apache/incubator-seata/pull/6198

   <!-- Please make sure you have read and understood the contributing guidelines -->
   
   - [ ] I have registered the PR [changes](../changes).
   
   ### Ⅰ. Describe what this PR did
   
   
   ### Ⅱ. Does this pull request fix one issue?
   
   
   ### Ⅲ. Why don't you add test cases (unit test/integration test)? 
   
   
   ### Ⅳ. Describe how to verify it
   
   
   ### Ⅴ. Special notes for reviews
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For additional commands, e-mail: dev-help@seata.apache.org

Re: [PR] Test: increase spring autoconfigure module unit test coverage [incubator-seata]

Posted by "l81893521 (via GitHub)" <gi...@apache.org>.
l81893521 closed pull request #6198: Test: increase spring autoconfigure module unit test coverage
URL: https://github.com/apache/incubator-seata/pull/6198


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org

Re: [PR] Test: increase spring autoconfigure module unit test coverage [incubator-seata]

Posted by "lightClouds917 (via GitHub)" <gi...@apache.org>.
lightClouds917 commented on code in PR #6198:
URL: https://github.com/apache/incubator-seata/pull/6198#discussion_r1446956759


##########
seata-spring-autoconfigure/seata-spring-autoconfigure-client/src/test/java/io/seata/spring/boot/autoconfigure/SeataClientEnvironmentPostProcessorTest.java:
##########
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package io.seata.spring.boot.autoconfigure;
+
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+import org.springframework.context.annotation.AnnotationConfigApplicationContext;
+import org.springframework.core.Ordered;
+
+/**
+ * @description:
+ * @author: zhangjiawei
+ * @date: 2024/1/2

Review Comment:
   remove author and date



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org

Re: [PR] Test: increase spring autoconfigure module unit test coverage [incubator-seata]

Posted by "l81893521 (via GitHub)" <gi...@apache.org>.
l81893521 commented on code in PR #6198:
URL: https://github.com/apache/incubator-seata/pull/6198#discussion_r1454593477


##########
seata-spring-autoconfigure/seata-spring-autoconfigure-client/src/test/java/io/seata/spring/boot/autoconfigure/SeataClientEnvironmentPostProcessorTest.java:
##########
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package io.seata.spring.boot.autoconfigure;
+
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+import org.springframework.context.annotation.AnnotationConfigApplicationContext;
+import org.springframework.core.Ordered;
+
+/**
+ * @description:
+ * @author: zhangjiawei
+ * @date: 2024/1/2

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org

Re: [PR] [WIP]Test: increase spring autoconfigure module unit test coverage [incubator-seata]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6198:
URL: https://github.com/apache/incubator-seata/pull/6198#issuecomment-1867812459

   ## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/6198?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Comparison is base [(`9a58770`)](https://app.codecov.io/gh/apache/incubator-seata/commit/9a587705cabbbd11adb346322de08031fdf1c490?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 48.99% compared to head [(`427489c`)](https://app.codecov.io/gh/apache/incubator-seata/pull/6198?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 48.98%.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   [![Impacted file tree graph](https://app.codecov.io/gh/apache/incubator-seata/pull/6198/graphs/tree.svg?width=650&height=150&src=pr&token=tbmHt2ZfxO&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/incubator-seata/pull/6198?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@             Coverage Diff              @@
   ##                2.x    #6198      +/-   ##
   ============================================
   - Coverage     48.99%   48.98%   -0.01%     
   + Complexity     4782     4781       -1     
   ============================================
     Files           915      915              
     Lines         31892    31892              
     Branches       3853     3853              
   ============================================
   - Hits          15624    15621       -3     
   - Misses        14706    14712       +6     
   + Partials       1562     1559       -3     
   ```
   
   
   [see 7 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/6198/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For additional commands, e-mail: dev-help@seata.apache.org

Re: [PR] Test: increase spring autoconfigure module unit test coverage [incubator-seata]

Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on code in PR #6198:
URL: https://github.com/apache/incubator-seata/pull/6198#discussion_r1452081888


##########
seata-spring-autoconfigure/seata-spring-autoconfigure-client/src/test/java/io/seata/spring/boot/autoconfigure/properties/SeataPropertiesTest.java:
##########


Review Comment:
   *PropertiesTest 我希望这些properties的get set的相关方法通过扫描包，解析类，进行反射将其中的method一次性处理掉，至于入参类型可以通过反射拿到参数类型，写一个switch等方式来处理。
   *PropertiesTest I want the get set related methods of these properties to scan the package, parse the class, and do reflection to get rid of the method once and for all, and as for the input parameter type can be dealt with by getting the parameter type through reflection, writing a switch, etc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org