You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/07/01 19:58:18 UTC

[GitHub] [nifi-minifi] mattyb149 opened a new pull request #193: MINIFI-245: Expose content repository implementation configuration

mattyb149 opened a new pull request #193:
URL: https://github.com/apache/nifi-minifi/pull/193


   Thank you for submitting a contribution to Apache NiFi - MiNiFi.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [x] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi-minifi folder?
   - [x] Have you written or updated unit tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](https://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under minifi-assembly?
   - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under minifi-assembly?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi] apiri commented on pull request #193: MINIFI-245: Expose content repository implementation configuration

Posted by GitBox <gi...@apache.org>.
apiri commented on pull request #193:
URL: https://github.com/apache/nifi-minifi/pull/193#issuecomment-653278515


   Travis seems to be having issues but I could not replicate them.  code, build and tests all look good here +1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi] apiri merged pull request #193: MINIFI-245: Expose content repository implementation configuration

Posted by GitBox <gi...@apache.org>.
apiri merged pull request #193:
URL: https://github.com/apache/nifi-minifi/pull/193


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi] apiri commented on pull request #193: MINIFI-245: Expose content repository implementation configuration

Posted by GitBox <gi...@apache.org>.
apiri commented on pull request #193:
URL: https://github.com/apache/nifi-minifi/pull/193#issuecomment-653276026


   reviewing


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org