You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/03/03 17:45:34 UTC

[GitHub] [couchdb] davisp commented on a change in pull request #3397: Allow applying per-transaction options with fabric2_fdb:transactional/3

davisp commented on a change in pull request #3397:
URL: https://github.com/apache/couchdb/pull/3397#discussion_r586639409



##########
File path: src/fabric/test/fabric2_tx_options_tests.erl
##########
@@ -101,9 +103,40 @@ can_configure_options_at_runtime(_) ->
     ok = fabric2_db:delete(DbName, [?ADMIN_CTX]).
 
 
+can_apply_options_to_db_name_transactions(_) ->
+    DbName = ?tempdb(),
+
+    TxFun = fun(TxDb) ->
+        #{tx := Tx} = TxDb,
+        fabric2_fdb:create(TxDb, [?ADMIN_CTX]),
+        erlfdb:wait(erlfdb:get(Tx, <<16#FF, "/primaryDatacenter">>))
+    end,
+    TxOpts = #{read_system_keys => <<>>},

Review comment:
       One thing for future improvements will be to figure out a better UI for these options that are booleans but expect an empty binary. I don't think that work belongs as part of this PR but it'd be nice to figure something out in the future.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org