You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2015/10/14 17:05:58 UTC

[GitHub] flink pull request: [FLINK-2851] Move PythonAPI to flink-libraries

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/1257

    [FLINK-2851] Move PythonAPI to flink-libraries

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink _move_libraries

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1257.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1257
    
----
commit f9d108973c3c01f56be557cf056f193a69728e75
Author: zentol <s....@web.de>
Date:   2015-10-14T14:49:31Z

    [FLINK-2851] Move PythonAPI to flink-libraries

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2851] Move PythonAPI to flink-libraries

Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/1257#issuecomment-155432214
  
    Hi @zentol, this is another step towards the Maven module refactoring that we decided to do.
    I think you can merge this PR to the master branch. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2851] Move PythonAPI to flink-libraries

Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1257#discussion_r42018555
  
    --- Diff: flink-libraries/flink-python/src/main/java/org/apache/flink/python/api/PythonOperationInfo.java ---
    @@ -1,3 +1,5 @@
    +package org.apache.flink.python.api;
    --- End diff --
    
    Fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2851] Move PythonAPI to flink-libraries

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/1257


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2851] Move PythonAPI to flink-libraries

Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the pull request:

    https://github.com/apache/flink/pull/1257#issuecomment-149221457
  
    I moved the PythonOperationInfo into a separate file (along with a few static helper methods). Apart from that i only merged the PlanBinder and PythonPlanBinder classes and simplified the code where it made sense.
    
    There is no longer a differentiation between Operation (non-UDF, handled by generic code) and AbstractOperations(UDF, handled by language-specific code), because there is no longer a reason to do that.
    
    Previously, to create e.g a flatMap operation you would first execute this code in PlanBinder:
    ```
    private void createFlatMapOperation(INFO info) {
    	DataSet op1 = (DataSet) sets.get(info.parentID);
    	sets.put(info.setID, applyFlatMapOperation(op1, info));}
    ```
    and then in PythonPlanBinder:
    ```
    @Override
    protected DataSet applyFlatMapOperation(DataSet op1, PythonOperationInfo info) {
    	return op1.mapPartition(new PythonMapPartition(info.setID, info.types)).name(info.name);}
    ```
    these methods introduced a lot of clutter so i merged them.
    
    I can't think of anything else i changed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2851] Move PythonAPI to flink-libraries

Posted by sachingoel0101 <gi...@git.apache.org>.
Github user sachingoel0101 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1257#discussion_r42016074
  
    --- Diff: flink-libraries/flink-python/src/main/java/org/apache/flink/python/api/PythonOperationInfo.java ---
    @@ -1,3 +1,5 @@
    +package org.apache.flink.python.api;
    --- End diff --
    
    This should be after the license.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2851] Move PythonAPI to flink-libraries

Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:

    https://github.com/apache/flink/pull/1257#issuecomment-149232075
  
    Ah, that makes sense and looks much cleaner. Thank you. +1 to merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2851] Move PythonAPI to flink-libraries

Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:

    https://github.com/apache/flink/pull/1257#issuecomment-149206297
  
    Looks like you did quite some refactoring e.g. in `FlinkPlanBinder`. Could you elaborate on your changes besides moving everything to flink-libraries?
    
    Otherwise +1 to merge.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---