[GitHub] [iceberg] kbendick commented on issue #1250: Some compiler warnings about ReferenceEquality and potentially fragile code

[GitBox <gi...@apache.org>]

kbendick commented on issue #1250:
URL: https://github.com/apache/iceberg/issues/1250#issuecomment-667441829


   Yes. For this one I imagine that most of them, if not all, will be suppressions. I will open a PR for this sometime this weekend or early next week. And then hopefully we can add a github action that blocks PRs on certain ErrorProne cases if people are open to it (at least for important things like ReferenceEquality).
   
   The @override thing wasn't really a big deal, but over time the Suppress Warning on things like reference equality will become more and more important as forms of documentation for the reader.
   
   Whether or not we want to block PRs yet is a separate issue.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org