You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "snuyanzin (via GitHub)" <gi...@apache.org> on 2023/11/11 15:12:47 UTC
[PR] [FLINK-33361] Add Java 17 compatibility to Flink Kafka connector [flink-connector-kafka]
snuyanzin opened a new pull request, #68:
URL: https://github.com/apache/flink-connector-kafka/pull/68
The PR adds compatibility with java 17
Also it adds `ci.yml` which allows to run tests with java 17
Once this will be enabled in shared ci (https://github.com/apache/flink-connector-shared-utils/pull/24) this `ci/yml` could be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33361][Connectors/Kafka] Add Java 17 compatibility to Flink Kafka connector [flink-connector-kafka]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #68:
URL: https://github.com/apache/flink-connector-kafka/pull/68#discussion_r1423178960
##########
pom.xml:
##########
@@ -78,6 +78,13 @@ under the License.
<log4j.version>2.17.1</log4j.version>
<flink.parent.artifactId>flink-connector-kafka-parent</flink.parent.artifactId>
+
+ <!-- This property should contain the add-opens/add-exports commands required for the tests
+ in the given connector's module to pass.
+ It MUST be a space-separated list not containing any newlines,
+ of entries in the form '[-]{2}add-[opens|exports]=<module>/<package>=ALL-UNNAMED'.-->
+ <flink.connector.module.config/>
+ <flink.surefire.baseArgLine>-XX:+UseG1GC -Xms256m -XX:+IgnoreUnrecognizedVMOptions ${flink.connector.module.config}</flink.surefire.baseArgLine>
Review Comment:
IIRC flags are configured in `flink-conf.yaml` at `env.java.opts.all` and all flags used here are already present there.
That means that currently there is nothing to do.
In theory in future there might appear such necessity e.g. because of some specific dependencies however I think it should be handled only once it is required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33361][Connectors/Kafka] Add Java 17 compatibility to Flink Kafka connector [flink-connector-kafka]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #68:
URL: https://github.com/apache/flink-connector-kafka/pull/68#issuecomment-1850970248
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33361][Connectors/Kafka] Add Java 17 compatibility to Flink Kafka connector [flink-connector-kafka]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin merged PR #68:
URL: https://github.com/apache/flink-connector-kafka/pull/68
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33361][Connectors/Kafka] Add Java 17 compatibility to Flink Kafka connector [flink-connector-kafka]
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on code in PR #68:
URL: https://github.com/apache/flink-connector-kafka/pull/68#discussion_r1422422887
##########
pom.xml:
##########
@@ -78,6 +78,13 @@ under the License.
<log4j.version>2.17.1</log4j.version>
<flink.parent.artifactId>flink-connector-kafka-parent</flink.parent.artifactId>
+
+ <!-- This property should contain the add-opens/add-exports commands required for the tests
+ in the given connector's module to pass.
+ It MUST be a space-separated list not containing any newlines,
+ of entries in the form '[-]{2}add-[opens|exports]=<module>/<package>=ALL-UNNAMED'.-->
+ <flink.connector.module.config/>
+ <flink.surefire.baseArgLine>-XX:+UseG1GC -Xms256m -XX:+IgnoreUnrecognizedVMOptions ${flink.connector.module.config}</flink.surefire.baseArgLine>
Review Comment:
Is there anything that we need to document for end-users, do they need to configure anything if they want to use the Flink Kafka connector with JDK17?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33361] Add Java 17 compatibility to Flink Kafka connector [flink-connector-kafka]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #68:
URL: https://github.com/apache/flink-connector-kafka/pull/68#issuecomment-1806840882
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33361][connectors/kafka] Add Java 17 compatibility to Flink Kafka connector [flink-connector-kafka]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #68:
URL: https://github.com/apache/flink-connector-kafka/pull/68#issuecomment-1807265659
@MartijnVisser do you happen to know what should be done to make title validation passing?
it seems it satisfies the regexp now, however it didn't with the first commit of the PR, then I force pushed it... Might that be a reason?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org