You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@fineract.apache.org by Ahmed Adel <a7...@gmail.com> on 2025/02/22 16:00:20 UTC

Request for Feedback on My PRs

Hey everyone,

I submitted PRs during last *two weeks ago* but haven't received any
feedback yet. This has been a bit frustrating, as I'm actively preparing
for *GSoC* and really need feedback to improve my work.

Here’s my general approach to solving issues and maintaining the codebase:

   - I pick up issues from the *Sonar report* and work on fixing them.
   - run the project and before the PR I am executing: ./gradlew
   spotlessApply spotbugsMain spotbugsTest checkstyleMain checkstyleTest

I’d really appreciate any feedback on my PRs so I can make any necessary
changes and continue contributing effectively.

Thanks in advance for your time!

Regards,
Ahmed Adel

Re: Request for Feedback on My PRs

Posted by Ádám Sághy <ad...@gmail.com>.
Hi Ahmed,

First of all, thank you very much for your contribution! I am sorry, you havent got any feedback, let me see what I can provide you during next week!

Keep up the good work!

Regards,
Adam

> On 2025. Feb 22., at 17:00, Ahmed Adel <a7...@gmail.com> wrote:
> 
> Hey everyone,
> 
> I submitted PRs during last two weeks ago but haven't received any feedback yet. This has been a bit frustrating, as I'm actively preparing for GSoC and really need feedback to improve my work.
> 
> Here’s my general approach to solving issues and maintaining the codebase:
> 
> I pick up issues from the Sonar report and work on fixing them.
> run the project and before the PR I am executing: ./gradlew spotlessApply spotbugsMain spotbugsTest checkstyleMain checkstyleTest 
> I’d really appreciate any feedback on my PRs so I can make any necessary changes and continue contributing effectively.
> 
> Thanks in advance for your time!
> 
> Regards,
> Ahmed Adel
>