You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2017/04/14 20:35:27 UTC

[kudu-CR](branch-1.3.x) docs: Fix "make site" 

Dan Burkert has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6643

Change subject: docs: Fix "make site"
......................................................................

docs: Fix "make site"

* "make site" was broken due to changed command-line argments on
  "docs/support/scripts/make_site.sh". This patch fixes that
  discrepancy.

* Also, assume the "apache" remote exists for the site build. That
  assumption is consistent with the "build-support/push_to_asf.py"
  script.

Change-Id: I9050eec37ea6b5b4917a4c8269de4178c3c14cb2
Reviewed-on: http://gerrit.cloudera.org:8080/6488
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
(cherry picked from commit b719b1e7c7e2a78f8e818a9c8275b5d030835811)
---
M CMakeLists.txt
M docs/support/scripts/make_site.sh
2 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/6643/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6643
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9050eec37ea6b5b4917a4c8269de4178c3c14cb2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.3.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR](branch-1.3.x) docs: Fix "make site"

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.

Change subject: docs: Fix "make site"
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/6643
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9050eec37ea6b5b4917a4c8269de4178c3c14cb2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.3.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR](branch-1.3.x) docs: Fix "make site"

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: docs: Fix "make site"
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/6643
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9050eec37ea6b5b4917a4c8269de4178c3c14cb2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.3.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR](branch-1.3.x) docs: Fix "make site"

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has submitted this change and it was merged.

Change subject: docs: Fix "make site"
......................................................................


docs: Fix "make site"

* "make site" was broken due to changed command-line argments on
  "docs/support/scripts/make_site.sh". This patch fixes that
  discrepancy.

* Also, assume the "apache" remote exists for the site build. That
  assumption is consistent with the "build-support/push_to_asf.py"
  script.

Change-Id: I9050eec37ea6b5b4917a4c8269de4178c3c14cb2
Reviewed-on: http://gerrit.cloudera.org:8080/6488
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
(cherry picked from commit b719b1e7c7e2a78f8e818a9c8275b5d030835811)
Reviewed-on: http://gerrit.cloudera.org:8080/6643
Reviewed-by: Mike Percy <mp...@apache.org>
---
M CMakeLists.txt
M docs/support/scripts/make_site.sh
2 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Mike Percy: Looks good to me, approved
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/6643
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9050eec37ea6b5b4917a4c8269de4178c3c14cb2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.3.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>