You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by pa...@apache.org on 2021/03/11 22:31:15 UTC
[beam] branch master updated: [BEAM-9372] remove python version
check whether python 3.6 above or not
This is an automated email from the ASF dual-hosted git repository.
pabloem pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git
The following commit(s) were added to refs/heads/master by this push:
new 18ad33a [BEAM-9372] remove python version check whether python 3.6 above or not
new 08bd566 Merge pull request #14184 from [BEAM-9372] remove python version check whether python 3.6 above or not
18ad33a is described below
commit 18ad33aa25a60465375de0a3ff0537cb0ae0941c
Author: yoshiki.obata <yo...@gmail.com>
AuthorDate: Wed Mar 10 21:54:42 2021 +0900
[BEAM-9372] remove python version check whether python 3.6 above or not
---
.../apache_beam/runners/interactive/interactive_environment.py | 6 ------
.../runners/interactive/testing/integration/screen_diff.py | 1 -
2 files changed, 7 deletions(-)
diff --git a/sdks/python/apache_beam/runners/interactive/interactive_environment.py b/sdks/python/apache_beam/runners/interactive/interactive_environment.py
index 12b7c4b..dc904c8 100644
--- a/sdks/python/apache_beam/runners/interactive/interactive_environment.py
+++ b/sdks/python/apache_beam/runners/interactive/interactive_environment.py
@@ -171,7 +171,6 @@ class InteractiveEnvironment(object):
self._computed_pcolls = set()
# Always watch __main__ module.
self.watch('__main__')
- self._is_py_version_ready = True
# Check if [interactive] dependencies are installed.
try:
import IPython # pylint: disable=unused-import
@@ -217,11 +216,6 @@ class InteractiveEnvironment(object):
return options
@property
- def is_py_version_ready(self):
- """If Python version is above the minimum requirement."""
- return self._is_py_version_ready
-
- @property
def is_interactive_ready(self):
"""If the [interactive] dependencies are installed."""
return self._is_interactive_ready
diff --git a/sdks/python/apache_beam/runners/interactive/testing/integration/screen_diff.py b/sdks/python/apache_beam/runners/interactive/testing/integration/screen_diff.py
index 57dc0a7..c17564e 100644
--- a/sdks/python/apache_beam/runners/interactive/testing/integration/screen_diff.py
+++ b/sdks/python/apache_beam/runners/interactive/testing/integration/screen_diff.py
@@ -127,7 +127,6 @@ def should_skip():
"""Whether a screen diff test should be skipped."""
return not (
platform.system() in _SUPPORTED_PLATFORMS and
- ie.current_env().is_py_version_ready and
ie.current_env().is_interactive_ready and _interactive_integration_ready)