[kudu-CR] [timestamp] Add a new TimestampValue class to support the TIMESTAMP NANOS type

["Andrew Wong (Code Review)" <ge...@cloudera.org>]

Andrew Wong has posted comments on this change.

Change subject: [timestamp] Add a new TimestampValue class to support the TIMESTAMP_NANOS type
......................................................................


Patch Set 9:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/5965/9/src/kudu/common/timestamp_value-internal.h
File src/kudu/common/timestamp_value-internal.h:

PS9, Line 25: he
nit: the


PS9, Line 25: : 1901-12-14 00:00:00
May not want/need to specify this, considering it's already noted in a few other places and it's dependent on the system.


http://gerrit.cloudera.org:8080/#/c/5965/9/src/kudu/common/timestamp_value.cc
File src/kudu/common/timestamp_value.cc:

PS9, Line 68: an 
nit: a


-- 
To view, visit http://gerrit.cloudera.org:8080/5965
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5a0763d3a28501b7f9fb0b94552e3227bd5b38cc
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes