Re: Review Request 74513: ATLAS-4762 : Basic search with classification as notNull/isNull returns wrong entities

[Pinal Shah <pi...@freestoneinfotech.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74513/
-----------------------------------------------------------

(Updated July 14, 2023, 7:27 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Mandar Ambawane, Radhika Kundam, and Sidharth Mishra.


Bugs: ATLAS-4762
    https://issues.apache.org/jira/browse/ATLAS-4762


Repository: atlas


Description
-------

**Issue:** When the classifications are added and then removed, the '_classificationNames' field is left with the empty string, hence onselecting null/notNull operators it returns wrong entities

**Cause:** It is because of Solr version upgrade, untill 8.4.1, Solr supported non empty string.

**Payload:** {
    'queryType': 'BASIC',
    'searchParameters': {
        'typeName': '_ALL_ENTITY_TYPES',
        'excludeDeletedEntities': True,
        'includeClassificationAttributes': False,
        'includeSubTypes': True,
        'includeSubClassifications': True,
        'excludeHeaderAttributes': False,
        'limit': 1000,
        'offset': 0,
        'entityFilters': {
            'condition': 'AND',
            'criterion': [{
                'attributeName': '__classificationNames',
                'operator': 'notNull',
                'attributeValue': ''
            }]
        },
        'attributes': []
    }
**Fix:** For IndexQuery : ["" TO *] works to get nonEmpty field entities
     For Inmemory Predicates: Used NonEmptyPredicate


Diffs
-----

  intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 1de1f122b 
  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 49091dcf3 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasBusinessMetadataDefStoreV2.java ece1a231e 
  repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java 3f9e74d11 


Diff: https://reviews.apache.org/r/74513/diff/3/


Testing
-------

Added unittest case


Thanks,

Pinal Shah