[jira] [Comment Edited] (HBASE-16584) Backport the new ipc implementation in HBASE-16432 to branch-1

["Duo Zhang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-16584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15898887#comment-15898887 ] 

Duo Zhang edited comment on HBASE-16584 at 3/7/17 7:49 AM:
-----------------------------------------------------------

A huge patch...

Next I will test the performance compare to the old implementation.


was (Author: apache9):
A hugh patch...

> Backport the new ipc implementation in HBASE-16432 to branch-1
> --------------------------------------------------------------
>
>                 Key: HBASE-16584
>                 URL: https://issues.apache.org/jira/browse/HBASE-16584
>             Project: HBase
>          Issue Type: Task
>          Components: Client, IPC/RPC
>    Affects Versions: 1.4.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 1.4.0
>
>         Attachments: HBASE-16584-branch-1.patch
>
>
> Two problems.
> First, as RpcCliemtImpl is the default implementation on branch-1, we need to confirm that the modification on master does not make it slower. I'm not sure but I used a big lock to protect everything in the new implementation, so it may have bad impact on performance.
> Second, some configurations of the old AsyncRpcClient is gone. Such as "hbase.rpc.client.threads.max" and "hbase.rpc.client.nativetransport". Now You could pass a EventLoopGroup object directly through a helper class which makes it more flexible.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)