You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@rya.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/07 15:59:04 UTC

[jira] [Commented] (RYA-278) AccumuloLoadStatements test fails due to filtering out mvm.rya predicates rather than org.apache.rya predicates

    [ https://issues.apache.org/jira/browse/RYA-278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15999914#comment-15999914 ] 

ASF GitHub Bot commented on RYA-278:
------------------------------------

GitHub user jwonders opened a pull request:

    https://github.com/apache/incubator-rya/pull/157

    RYA-278 Fixes AccumuloLoadStatements::loadTurtleFile test

    <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
    
      http://www.apache.org/licenses/LICENSE-2.0
    
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
    ## Description
    Ignores `org.apache.rya` predicates rather than `mvm.rya` predicates to filter out rya version metadata.  This update appears to have been overlooked when the URIs were changed.
    
    ### Tests
    No additional tests were written as this fixes an existing test.
    
    ### Links
    [Jira](https://issues.apache.org/jira/browse/RYA-278)
    
    ### Checklist
    - [ ] Code Review
    - [ ] Squash Commits
    
    #### People To Reivew
    @amihalik @pujav65 


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jwonders/incubator-rya b/RYA-278-fix-load-statements-test

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-rya/pull/157.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #157
    
----
commit 1573150b6a6cfafe64b732c033b973e44ea378c1
Author: Jonathan Wonders <jw...@gmail.com>
Date:   2017-05-07T15:52:16Z

    RYA-278 Fixes AccumuloLoadStatements::loadTurtleFile test
    
    Ignores org.apache.rya predicates rather than mvm.rya predicates
    to filter out rya version metadata.

----


> AccumuloLoadStatements test fails due to filtering out mvm.rya predicates rather than org.apache.rya predicates
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: RYA-278
>                 URL: https://issues.apache.org/jira/browse/RYA-278
>             Project: Rya
>          Issue Type: Bug
>          Components: dao
>            Reporter: Jonathan Wonders
>            Assignee: Jonathan Wonders
>            Priority: Trivial
>              Labels: easyfix, newbie, test
>
> The loadTurtleFile test case fails becuase the set of statements collected from the iterator includes version and rts statements.  It looks like the test intends to filter these out, but it filters them based on an {{mvm.rya}} uri which has since changed to {{org.apache.rya}}
> {noformat}
> java.lang.AssertionError: 
> Expected :[(http://example#alice, http://example#talksTo, http://example#bob), (http://example#bob, http://example#talksTo, http://example#charlie), (http://example#charlie, http://example#likes, http://example#icecream)]
> Actual   :[(http://example#alice, http://example#talksTo, http://example#bob), (http://example#bob, http://example#talksTo, http://example#charlie), (http://example#charlie, http://example#likes, http://example#icecream), (urn:org.apache.rya/2012/05#rts, urn:org.apache.rya/2012/05#version, "3.0.0")]
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)