[GitHub] ahgittin commented on a change in pull request #125: Fix errors around locations in composer

[GitBox <gi...@apache.org>]

ahgittin commented on a change in pull request #125: Fix errors around locations in composer
URL: https://github.com/apache/brooklyn-ui/pull/125#discussion_r261214288
 
 

 ##########
 File path: ui-modules/blueprint-composer/app/components/providers/blueprint-service.provider.js
 ##########
 @@ -603,16 +616,24 @@ function BlueprintService($log, $q, $sce, paletteApi, iconGenerator, dslService)
 
     function populateLocationFromApiSuccess(entity, data) {
         entity.clearIssues({group: 'location'});
-        entity.location = data.symbolicName;
-        entity.miscData.set('locationName', data.name);
-        entity.miscData.set('locationIcon', data.iconUrl || iconGenerator(data.symbolicName));
+        entity.location = data.yamlHere || data.symbolicName;
 
 Review comment:
   i wanted something that obviously wouldn't conflict.  it could be `yamlOverride` but to me, `Here` conveys that it is _not_ part of any external spec.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services