You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ranger.apache.org by Mugdha Varadkar <mu...@gmail.com> on 2024/02/28 13:44:51 UTC

Re: Review Request 74886: RANGER-4718 : Skip showing 'Page not found' page for INVALID_INPUT_DATA validation in User Profile

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74886/
-----------------------------------------------------------

(Updated Feb. 28, 2024, 1:44 p.m.)

Review request for ranger, Brijesh Bhalala and Dhaval Rajpara.

Bugs: RANGER-4718
https://issues.apache.org/jira/browse/RANGER-4718

Repository: ranger

Description
-------

When user provides invalid form values during profile update, the Ranger React UI shows 'Page not found' page. Need to skip showing 'Page not found' page for such scenario and show the server-side response as an alert on User Profile page.

Also taking care of a minor issue, where email address is getting reset to empty at a time of password change on User Profile page.

Diffs
-----

security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserFormComp.jsx 64a536c0c18446822529fc6c885efaa0a17302a7
security-admin/src/main/webapp/react-webapp/src/views/UserProfile.jsx 64c695b33069c21806dc649842f266f95cb5ea25

Diff: https://reviews.apache.org/r/74886/diff/2/

Testing
-------

Tested changes on a cluster setup with Ranger Admin build with React JS code base.

Verified the 'page not found' page is not shown on Ranger React UI when server side throws INVALID_INPUT_DATA validation error. The error is shown as an alert on UI. Also verified email address is not getting reset to empty at time of password change.

Successful completion of build command :
mvn clean compile package

Thanks,

Mugdha Varadkar