You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Nitiraj Rathore <ni...@gmail.com> on 2017/01/06 14:43:48 UTC

Review Request 55267: Hive View 2.0 : add REST endpoint for deleting database

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55267/
-----------------------------------------------------------

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-19403
    https://issues.apache.org/jira/browse/AMBARI-19403


Repository: ambari


Description
-------

Added rest endpoint and query generator and service method for the same.


Diffs
-----

  contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/DeleteDatabaseQueryGenerator.java PRE-CREATION 
  contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLProxy.java 8c37a96 
  contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLService.java b278983 
  contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/DeleteDatabaseQueryGeneratorSpecTest.groovy PRE-CREATION 
  contrib/views/hive20/src/test/rest/postman/hive20.postman_collection.json b6d84b3 

Diff: https://reviews.apache.org/r/55267/diff/


Testing
-------

added test class DeleteDatabaseQueryGeneratorSpecTest


Thanks,

Nitiraj Rathore


Re: Review Request 55267: Hive View 2.0 : add REST endpoint for deleting database

Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55267/#review161054
-----------------------------------------------------------


Ship it!




Ship It!

- Gaurav Nagar


On Jan. 6, 2017, 2:43 p.m., Nitiraj Rathore wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55267/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2017, 2:43 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19403
>     https://issues.apache.org/jira/browse/AMBARI-19403
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Added rest endpoint and query generator and service method for the same.
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/DeleteDatabaseQueryGenerator.java PRE-CREATION 
>   contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLProxy.java 8c37a96 
>   contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLService.java b278983 
>   contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/DeleteDatabaseQueryGeneratorSpecTest.groovy PRE-CREATION 
>   contrib/views/hive20/src/test/rest/postman/hive20.postman_collection.json b6d84b3 
> 
> Diff: https://reviews.apache.org/r/55267/diff/
> 
> 
> Testing
> -------
> 
> added test class DeleteDatabaseQueryGeneratorSpecTest
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>


Re: Review Request 55267: Hive View 2.0 : add REST endpoint for deleting database

Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55267/#review161053
-----------------------------------------------------------


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Jan. 6, 2017, 2:43 p.m., Nitiraj Rathore wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55267/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2017, 2:43 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19403
>     https://issues.apache.org/jira/browse/AMBARI-19403
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Added rest endpoint and query generator and service method for the same.
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/DeleteDatabaseQueryGenerator.java PRE-CREATION 
>   contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLProxy.java 8c37a96 
>   contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLService.java b278983 
>   contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/DeleteDatabaseQueryGeneratorSpecTest.groovy PRE-CREATION 
>   contrib/views/hive20/src/test/rest/postman/hive20.postman_collection.json b6d84b3 
> 
> Diff: https://reviews.apache.org/r/55267/diff/
> 
> 
> Testing
> -------
> 
> added test class DeleteDatabaseQueryGeneratorSpecTest
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>