You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Michael Osipov <mi...@apache.org> on 2023/01/04 19:10:41 UTC

[VOTE] Release Maven Fluido Skin version 2.0.0-M1

Hi,

We solved 6 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317926&version=12331576

There are still a couple of issues left in JIRA:
https://issues.apache.org/jira/issues/?jql=project%20%3D%20MSKINS%20AND%20resolution%20%3D%20Unresolved%20AND%20component%20%3D%20%22Fluido%20Skin%22

Staging repo:
https://repository.apache.org/content/repositories/maven-1840/
https://repository.apache.org/content/repositories/maven-1840/org/apache/maven/skins/maven-fluido-skin/2.0.0-M1/maven-fluido-skin-2.0.0-M1-source-release.zip

Source release checksum(s):
maven-fluido-skin-2.0.0-M1-source-release.zip
sha512: 
f956cd4ff0497cfd39c7d65dd3b91c1cc479291da867f8830d7754960809c2ff2265ad152effefe56216089344da1ad692b390c9a9254cf7c24678e96c3d6979

Staging site:
https://maven.apache.org/components/skins-archives/maven-fluido-skin-LATEST/

Guide to testing staged releases:
https://maven.apache.org/guides/development/guide-testing-releases.html

Vote open for 72 hours.

[ ] +1
[ ] +0
[ ] -1

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Re: [VOTE] Release Maven Fluido Skin version 2.0.0-M1

Posted by Michael Osipov <mi...@apache.org>.
Am 2023-01-04 um 20:10 schrieb Michael Osipov:
> Hi,
> 
> We solved 6 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317926&version=12331576
> 
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MSKINS%20AND%20resolution%20%3D%20Unresolved%20AND%20component%20%3D%20%22Fluido%20Skin%22
> 
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1840/
> https://repository.apache.org/content/repositories/maven-1840/org/apache/maven/skins/maven-fluido-skin/2.0.0-M1/maven-fluido-skin-2.0.0-M1-source-release.zip
> 
> Source release checksum(s):
> maven-fluido-skin-2.0.0-M1-source-release.zip
> sha512: 
> f956cd4ff0497cfd39c7d65dd3b91c1cc479291da867f8830d7754960809c2ff2265ad152effefe56216089344da1ad692b390c9a9254cf7c24678e96c3d6979
> 
> Staging site:
> https://maven.apache.org/components/skins-archives/maven-fluido-skin-LATEST/
> 
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
> 
> Vote open for 72 hours.

+1


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Re: [VOTE] Release Maven Fluido Skin version 2.0.0-M1

Posted by Michael Osipov <mi...@apache.org>.
Am 2023-01-06 um 12:55 schrieb Slawomir Jaranowski:
> Something is not ok ... please look at generated report - look strange
> ... missing tables
> 
> https://maven.apache.org/components/skins-archives/maven-fluido-skin-LATEST/dependency-convergence.html

Vote started.

> https://maven.apache.org/components/skins-archives/maven-fluido-skin-LATEST/surefire-report.html

 From Surefire code:
>     /**
>      * If set to true the surefire report will be generated even when there are no surefire result files.
>      * Defaults to {@code true} to preserve legacy behaviour pre 2.10.
>      * @since 2.11
>      */
>     @Parameter( defaultValue = "true", property = "alwaysGenerateSurefireReport" )
>     private boolean alwaysGenerateSurefireReport;

Must be set to false and renamed to 'skipEmptyReport' like we do in 
other plugins: 
https://github.com/search?l=Java&q=org%3Aapache+skipEmptyReport&type=Code

Here as well:
>     /**
>      * If set to true the failsafe report will be generated even when there are no failsafe result files.
>      * Defaults to {@code false} to preserve legacy behaviour pre 2.10.
>      * @since 2.11
>      */
>     @Parameter( defaultValue = "false", property = "alwaysGenerateFailsafeReport" )
>     private boolean alwaysGenerateFailsafeReport;

> https://maven.apache.org/components/skins-archives/maven-fluido-skin-LATEST/checkstyle.html

Vote started.

> https://maven.apache.org/components/skins-archives/maven-fluido-skin-LATEST/invoker-report.html

Outdated plugin is used. In 3.4.0 issue is fixed already.

M

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Re: [VOTE] Release Maven Fluido Skin version 2.0.0-M1

Posted by Michael Osipov <mi...@apache.org>.
Am 2023-01-06 um 12:55 schrieb Slawomir Jaranowski:
> Something is not ok ... please look at generated report - look strange
> ... missing tables
> 
> https://maven.apache.org/components/skins-archives/maven-fluido-skin-LATEST/dependency-convergence.html
> https://maven.apache.org/components/skins-archives/maven-fluido-skin-LATEST/surefire-report.html
> https://maven.apache.org/components/skins-archives/maven-fluido-skin-LATEST/checkstyle.html
> https://maven.apache.org/components/skins-archives/maven-fluido-skin-LATEST/invoker-report.html

OK, now, this I can explain: the have is correct. In Doxia 1.x there was 
a compat mode not to explicitly initiate the table with a Sink it was 
autocompleted. In Doxia all of that old code was removed. Since Maven 
Site Plugin 4.0.0-M4 is used, but the reporting plugins are still at 
Doxia 1.x we see the result now. I have for all of our plugins branches 
with all the necessary fixes. I am thinking whether I should do some 
backports to fix the issue even now with Doxia 1.x compatible plugins or 
release new major milestones of those plugins, but this would ultimately 
mean that they won't be compatible with Maven Site Plugin 3.x anymore.

For me, not a blocker ATM. Ugly, but I can live with for this release.

M


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Re: [VOTE] Release Maven Fluido Skin version 2.0.0-M1

Posted by Michael Osipov <mi...@apache.org>.
Am 2023-01-06 um 12:55 schrieb Slawomir Jaranowski:
> Something is not ok ... please look at generated report - look strange
> ... missing tables
> 
> https://maven.apache.org/components/skins-archives/maven-fluido-skin-LATEST/dependency-convergence.html
> https://maven.apache.org/components/skins-archives/maven-fluido-skin-LATEST/surefire-report.html
> https://maven.apache.org/components/skins-archives/maven-fluido-skin-LATEST/checkstyle.html
> https://maven.apache.org/components/skins-archives/maven-fluido-skin-LATEST/invoker-report.html

Thank you, this is weird. I will check...


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Re: [VOTE] Release Maven Fluido Skin version 2.0.0-M1

Posted by Slawomir Jaranowski <s....@gmail.com>.
Something is not ok ... please look at generated report - look strange
... missing tables

https://maven.apache.org/components/skins-archives/maven-fluido-skin-LATEST/dependency-convergence.html
https://maven.apache.org/components/skins-archives/maven-fluido-skin-LATEST/surefire-report.html
https://maven.apache.org/components/skins-archives/maven-fluido-skin-LATEST/checkstyle.html
https://maven.apache.org/components/skins-archives/maven-fluido-skin-LATEST/invoker-report.html


śr., 4 sty 2023 o 20:10 Michael Osipov <mi...@apache.org> napisał(a):

> Hi,
>
> We solved 6 issues:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317926&version=12331576
>
> There are still a couple of issues left in JIRA:
>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MSKINS%20AND%20resolution%20%3D%20Unresolved%20AND%20component%20%3D%20%22Fluido%20Skin%22
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1840/
>
> https://repository.apache.org/content/repositories/maven-1840/org/apache/maven/skins/maven-fluido-skin/2.0.0-M1/maven-fluido-skin-2.0.0-M1-source-release.zip
>
> Source release checksum(s):
> maven-fluido-skin-2.0.0-M1-source-release.zip
> sha512:
>
> f956cd4ff0497cfd39c7d65dd3b91c1cc479291da867f8830d7754960809c2ff2265ad152effefe56216089344da1ad692b390c9a9254cf7c24678e96c3d6979
>
> Staging site:
>
> https://maven.apache.org/components/skins-archives/maven-fluido-skin-LATEST/
>
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>

-- 
Sławomir Jaranowski

Re: [VOTE] Release Maven Fluido Skin version 2.0.0-M1

Posted by Hervé Boutemy <he...@free.fr>.
done in https://issues.apache.org/jira/browse/MSKINS-204

another small finding: we should remove mirror from all download templates
https://maven.apache.org/components/skins-archives/maven-fluido-skin-LATEST/
download.cgi

Regards,

Hervé

Le samedi 7 janvier 2023, 23:58:58 CET Michael Osipov a écrit :
> Am 2023-01-07 um 23:57 schrieb Herve Boutemy:
> > +1
> > 
> > Reproducible Builds ok: reference build done with JDK 8 on Windows
> > 
> > notice that 2 ITs failed:
> > [ERROR] The following builds failed:
> > [ERROR] *  mskins-76_topbar/pom.xml
> > [ERROR] *  mskins-76/pom.xml
> > The text counting patterns looks a little bit fragile
> 
> Interesting...Can you upload a tarball of target/it? I'd like to take a
> look at it.
> 
> M
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org





---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Re: [VOTE] Release Maven Fluido Skin version 2.0.0-M1

Posted by Michael Osipov <mi...@apache.org>.
Am 2023-01-07 um 23:57 schrieb Herve Boutemy:
> +1
> 
> Reproducible Builds ok: reference build done with JDK 8 on Windows
> 
> notice that 2 ITs failed:
> [ERROR] The following builds failed:
> [ERROR] *  mskins-76_topbar/pom.xml
> [ERROR] *  mskins-76/pom.xml
> The text counting patterns looks a little bit fragile

Interesting...Can you upload a tarball of target/it? I'd like to take a 
look at it.

M


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Re: [VOTE] Release Maven Fluido Skin version 2.0.0-M1

Posted by Herve Boutemy <hb...@apache.org>.
+1

Reproducible Builds ok: reference build done with JDK 8 on Windows

notice that 2 ITs failed:
[ERROR] The following builds failed:
[ERROR] *  mskins-76_topbar/pom.xml
[ERROR] *  mskins-76/pom.xml
The text counting patterns looks a little bit fragile

Regards,

Hervé

On 2023/01/04 19:10:41 Michael Osipov wrote:
> Hi,
> 
> We solved 6 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317926&version=12331576
> 
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MSKINS%20AND%20resolution%20%3D%20Unresolved%20AND%20component%20%3D%20%22Fluido%20Skin%22
> 
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1840/
> https://repository.apache.org/content/repositories/maven-1840/org/apache/maven/skins/maven-fluido-skin/2.0.0-M1/maven-fluido-skin-2.0.0-M1-source-release.zip
> 
> Source release checksum(s):
> maven-fluido-skin-2.0.0-M1-source-release.zip
> sha512: 
> f956cd4ff0497cfd39c7d65dd3b91c1cc479291da867f8830d7754960809c2ff2265ad152effefe56216089344da1ad692b390c9a9254cf7c24678e96c3d6979
> 
> Staging site:
> https://maven.apache.org/components/skins-archives/maven-fluido-skin-LATEST/
> 
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
> 
> Vote open for 72 hours.
> 
> [ ] +1
> [ ] +0
> [ ] -1
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Re: [VOTE] Release Maven Fluido Skin version 2.0.0-M1

Posted by Sylwester Lachiewicz <sl...@gmail.com>.
+1

śr., 4 sty 2023, 20:10 użytkownik Michael Osipov <mi...@apache.org>
napisał:

> Hi,
>
> We solved 6 issues:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317926&version=12331576
>
> There are still a couple of issues left in JIRA:
>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MSKINS%20AND%20resolution%20%3D%20Unresolved%20AND%20component%20%3D%20%22Fluido%20Skin%22
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1840/
>
> https://repository.apache.org/content/repositories/maven-1840/org/apache/maven/skins/maven-fluido-skin/2.0.0-M1/maven-fluido-skin-2.0.0-M1-source-release.zip
>
> Source release checksum(s):
> maven-fluido-skin-2.0.0-M1-source-release.zip
> sha512:
>
> f956cd4ff0497cfd39c7d65dd3b91c1cc479291da867f8830d7754960809c2ff2265ad152effefe56216089344da1ad692b390c9a9254cf7c24678e96c3d6979
>
> Staging site:
>
> https://maven.apache.org/components/skins-archives/maven-fluido-skin-LATEST/
>
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>

Re: [VOTE] Release Maven Fluido Skin version 2.0.0-M1

Posted by Slawomir Jaranowski <s....@gmail.com>.
+1

śr., 4 sty 2023 o 20:10 Michael Osipov <mi...@apache.org> napisał(a):

> Hi,
>
> We solved 6 issues:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317926&version=12331576
>
> There are still a couple of issues left in JIRA:
>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MSKINS%20AND%20resolution%20%3D%20Unresolved%20AND%20component%20%3D%20%22Fluido%20Skin%22
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1840/
>
> https://repository.apache.org/content/repositories/maven-1840/org/apache/maven/skins/maven-fluido-skin/2.0.0-M1/maven-fluido-skin-2.0.0-M1-source-release.zip
>
> Source release checksum(s):
> maven-fluido-skin-2.0.0-M1-source-release.zip
> sha512:
>
> f956cd4ff0497cfd39c7d65dd3b91c1cc479291da867f8830d7754960809c2ff2265ad152effefe56216089344da1ad692b390c9a9254cf7c24678e96c3d6979
>
> Staging site:
>
> https://maven.apache.org/components/skins-archives/maven-fluido-skin-LATEST/
>
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>

-- 
Sławomir Jaranowski

[CANCELED] [VOTE] Release Maven Fluido Skin version 2.0.0-M1

Posted by Michael Osipov <mi...@apache.org>.
I am canceling the vote, during the process and some discussions with 
Hervé I have found some subtile regressions caused by me. I will address 
them and respin soon.

M