You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2022/03/14 14:27:06 UTC
[GitHub] [libcloud] Germandrummer92 opened a new pull request #1666: Fix codecov
Germandrummer92 opened a new pull request #1666:
URL: https://github.com/apache/libcloud/pull/1666
## Fix coverage
### Description
I saw as part of [1664](https://github.com/apache/libcloud/pull/1664) that coverage is currently being collected also for the tests folder, this ignores them
### Status
- done, ready for review
### Checklist (tick everything that applies)
- [X] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
- [X] Documentation
- [X] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [X] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami commented on pull request #1666: Fix codecov
Posted by GitBox <gi...@apache.org>.
Kami commented on pull request #1666:
URL: https://github.com/apache/libcloud/pull/1666#issuecomment-1067381431
Thanks for the contribution.
Just curious on the context for this change. A lot of projects (including Libcloud) intentionally include tests in the coverage report - the idea is to see which tests are executed (aka tests code coverage should be close too 100% otherwise that likely indicates an issue with dead / unreachable tests).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami commented on pull request #1666: Fix codecov
Posted by GitBox <gi...@apache.org>.
Kami commented on pull request #1666:
URL: https://github.com/apache/libcloud/pull/1666#issuecomment-1067750580
1) Yeah, if we could split actual package and tests code in two separate reports that would be ideal, but I'm not sure if it's possible to do that with codecov.
2) The diff page does also seem to list those files, but it's hidden / non-expanded by default (I assume that's because the files weren't directly modified by this PR, but the coverage still changed) so I also missed it at first - https://app.codecov.io/gh/apache/libcloud/compare/1664/diff
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Germandrummer92 closed pull request #1666: Fix codecov
Posted by GitBox <gi...@apache.org>.
Germandrummer92 closed pull request #1666:
URL: https://github.com/apache/libcloud/pull/1666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Germandrummer92 commented on pull request #1666: Fix codecov
Posted by GitBox <gi...@apache.org>.
Germandrummer92 commented on pull request #1666:
URL: https://github.com/apache/libcloud/pull/1666#issuecomment-1068933644
okay thanks, makes sense 👍 Closing this then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Germandrummer92 commented on pull request #1666: Fix codecov
Posted by GitBox <gi...@apache.org>.
Germandrummer92 commented on pull request #1666:
URL: https://github.com/apache/libcloud/pull/1666#issuecomment-1067672108
Huh. That is a very good point. I don't think I have seen coverage used that way before, but you learn something new every day. 🙂
Then two questions however:
1) would it make sense to split the test package coverage + production code coverage into two numbers? Both would represent the intention better (one is to find "dead" test code) one to really check how well the production code is tested.
2) Why I started with this anyways: The Codecov comment on [1664](https://github.com/apache/libcloud/pull/1664#issuecomment-1066069396) looks to me like the coverage of `test_connection.py` and `test_local.py` went down, however on the codecov page itself it doesn't show those files as having [Coverage Changes](https://app.codecov.io/gh/apache/libcloud/compare/1664/changes), am I misunderstanding the table from codecov?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org