You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/05/28 07:49:32 UTC

[GitHub] [flink] paul8263 opened a new pull request #16017: [hotfix][doc] Correct code sample issues in Create a TableEnvironment…

paul8263 opened a new pull request #16017:
URL: https://github.com/apache/flink/pull/16017


   … chapter in table/common.md
   
   ## What is the purpose of the change
   
   Correct code sample issues in Create a TableEnvironment chapter in table/common.md
   
   ## Brief change log
   
   - docs/content/docs/dev/table/common.md
   
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16017: [hotfix][doc] Correct code sample issues in Create a TableEnvironment…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16017:
URL: https://github.com/apache/flink/pull/16017#issuecomment-850273435


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4cac6433d71c72a5c3c954d461d3d39bca94a949",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18390",
       "triggerID" : "4cac6433d71c72a5c3c954d461d3d39bca94a949",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4cac6433d71c72a5c3c954d461d3d39bca94a949",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18390",
       "triggerID" : "974000267",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 4cac6433d71c72a5c3c954d461d3d39bca94a949 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18390) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16017: [hotfix][doc] Correct code sample issues in Create a TableEnvironment…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16017:
URL: https://github.com/apache/flink/pull/16017#issuecomment-850273435


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4cac6433d71c72a5c3c954d461d3d39bca94a949",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18390",
       "triggerID" : "4cac6433d71c72a5c3c954d461d3d39bca94a949",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4cac6433d71c72a5c3c954d461d3d39bca94a949 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18390) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #16017: [hotfix][doc] Correct code sample issues in Create a TableEnvironment…

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16017:
URL: https://github.com/apache/flink/pull/16017#issuecomment-850230650


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 4cac6433d71c72a5c3c954d461d3d39bca94a949 (Fri May 28 08:00:59 UTC 2021)
   
   **Warnings:**
    * Documentation files were touched, but no `docs/content.zh/` files: Update Chinese documentation or file Jira ticket.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16017: [hotfix][doc] Correct code sample issues in Create a TableEnvironment…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16017:
URL: https://github.com/apache/flink/pull/16017#issuecomment-850273435


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4cac6433d71c72a5c3c954d461d3d39bca94a949",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18390",
       "triggerID" : "4cac6433d71c72a5c3c954d461d3d39bca94a949",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4cac6433d71c72a5c3c954d461d3d39bca94a949 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18390) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16017: [hotfix][doc] Correct code sample issues in Create a TableEnvironment…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16017:
URL: https://github.com/apache/flink/pull/16017#issuecomment-850230650


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 4cac6433d71c72a5c3c954d461d3d39bca94a949 (Fri May 28 11:11:56 UTC 2021)
   
   **Warnings:**
    * Documentation files were touched, but no `docs/content.zh/` files: Update Chinese documentation or file Jira ticket.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #16017: [hotfix][doc] Correct code sample issues in Create a TableEnvironment…

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16017:
URL: https://github.com/apache/flink/pull/16017#issuecomment-850273435


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4cac6433d71c72a5c3c954d461d3d39bca94a949",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4cac6433d71c72a5c3c954d461d3d39bca94a949",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4cac6433d71c72a5c3c954d461d3d39bca94a949 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] RocMarshal commented on pull request #16017: [hotfix][doc] Correct code sample issues in Create a TableEnvironment…

Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #16017:
URL: https://github.com/apache/flink/pull/16017#issuecomment-974000267


   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16017: [hotfix][doc] Correct code sample issues in Create a TableEnvironment…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16017:
URL: https://github.com/apache/flink/pull/16017#issuecomment-850273435


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4cac6433d71c72a5c3c954d461d3d39bca94a949",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18390",
       "triggerID" : "4cac6433d71c72a5c3c954d461d3d39bca94a949",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4cac6433d71c72a5c3c954d461d3d39bca94a949 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18390) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] SteNicholas removed a comment on pull request #16017: [hotfix][doc] Correct code sample issues in Create a TableEnvironment…

Posted by GitBox <gi...@apache.org>.
SteNicholas removed a comment on pull request #16017:
URL: https://github.com/apache/flink/pull/16017#issuecomment-850239328


   @paul8263 , IMO, you could change the Chinese docs together for this change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] SteNicholas commented on pull request #16017: [hotfix][doc] Correct code sample issues in Create a TableEnvironment…

Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #16017:
URL: https://github.com/apache/flink/pull/16017#issuecomment-850239328


   @paul8263 , IMO, you could change the Chinese docs together for this change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16017: [hotfix][doc] Correct code sample issues in Create a TableEnvironment…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16017:
URL: https://github.com/apache/flink/pull/16017#issuecomment-850273435


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4cac6433d71c72a5c3c954d461d3d39bca94a949",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18390",
       "triggerID" : "4cac6433d71c72a5c3c954d461d3d39bca94a949",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4cac6433d71c72a5c3c954d461d3d39bca94a949",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18390",
       "triggerID" : "974000267",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 4cac6433d71c72a5c3c954d461d3d39bca94a949 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18390) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] paul8263 closed pull request #16017: [hotfix][doc] Correct code sample issues in Create a TableEnvironment…

Posted by GitBox <gi...@apache.org>.
paul8263 closed pull request #16017:
URL: https://github.com/apache/flink/pull/16017


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org