[lucene-solr] branch branch_8x updated: SOLR-13268: Clean up any test failures resulting from defaulting to async logging. Put TestXmlQParser back

[er...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

erick pushed a commit to branch branch_8x
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git


The following commit(s) were added to refs/heads/branch_8x by this push:
     new a87ba09  SOLR-13268: Clean up any test failures resulting from defaulting to async logging. Put TestXmlQParser back
a87ba09 is described below

commit a87ba09e11a9bce4e5d97e3f713afe261112efc5
Author: Erick Erickson <Er...@gmail.com>
AuthorDate: Mon Mar 11 21:40:23 2019 -0700

    SOLR-13268: Clean up any test failures resulting from defaulting to async logging. Put TestXmlQParser back
    
    (cherry picked from commit b893548d97f8b04b40dfbebd79bd860603b92c63)
---
 .../tools/src/groovy/check-source-patterns.groovy  |  4 +-
 .../org/apache/solr/search/TestXmlQParser.java     | 55 ++++++++++++++++++++++
 2 files changed, 58 insertions(+), 1 deletion(-)

diff --git a/lucene/tools/src/groovy/check-source-patterns.groovy b/lucene/tools/src/groovy/check-source-patterns.groovy
index f0007ea..ccfcc49 100644
--- a/lucene/tools/src/groovy/check-source-patterns.groovy
+++ b/lucene/tools/src/groovy/check-source-patterns.groovy
@@ -182,7 +182,9 @@ ant.fileScanner{
       checkMockitoAssume(f, text);
     }
 
-    if (f.path.substring(baseDirLen).contains("solr/") && f.name.equals("SolrTestCase.java") == false) {
+    if (f.path.substring(baseDirLen).contains("solr/")
+        && f.name.equals("SolrTestCase.java") == false
+        && f.name.equals("TestXmlQParser.java") == false) {
       if (extendsLuceneTestCasePattern.matcher(text).find()) {
         reportViolation(f, "Solr test cases should extend SolrTestCase rather than LuceneTestCase");
       }
diff --git a/solr/core/src/test/org/apache/solr/search/TestXmlQParser.java b/solr/core/src/test/org/apache/solr/search/TestXmlQParser.java
new file mode 100644
index 0000000..76ed752
--- /dev/null
+++ b/solr/core/src/test/org/apache/solr/search/TestXmlQParser.java
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.solr.search;
+
+import java.lang.invoke.MethodHandles;
+
+import org.apache.lucene.queryparser.xml.CoreParser;
+
+import org.apache.lucene.queryparser.xml.TestCoreParser;
+import org.apache.solr.util.StartupLoggingUtils;
+import org.junit.AfterClass;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class TestXmlQParser extends TestCoreParser {
+
+  private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+  private CoreParser solrCoreParser;
+
+  @AfterClass
+  public static void shutdownLogger() throws Exception {
+    StartupLoggingUtils.shutdown();
+  }
+
+  @Override
+  protected CoreParser coreParser() {
+    if (solrCoreParser == null) {
+      solrCoreParser = new SolrCoreParser(
+          super.defaultField(),
+          super.analyzer(),
+          null);
+    }
+    return solrCoreParser;
+  }
+
+  //public void testSomeOtherQuery() {
+  //  Query q = parse("SomeOtherQuery.xml");
+  //  dumpResults("SomeOtherQuery", q, ?);
+  //}
+
+}