You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/06 02:42:24 UTC
[GitHub] [spark] imback82 opened a new pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
imback82 opened a new pull request #30270:
URL: https://github.com/apache/spark/pull/30270
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR proposes to migrate `LOAD DATA` to use `UnresolvedTable` to resolve the table identifier. This allows consistent resolution rules (temp view first, etc.) to be applied for both v1/v2 commands. More info about the consistent resolution rule proposal can be found in [JIRA](https://issues.apache.org/jira/browse/SPARK-29900) or [proposal doc](https://docs.google.com/document/d/1hvLjGA8y_W_hhilpngXVub1Ebv8RsMap986nENCFnrg/edit?usp=sharing).
Note that `LOAD DATA` is not supported for v2 tables.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
The changes allow consistent resolution behavior when resolving the table identifier. For example, the following is the current behavior:
```scala
sql("CREATE TEMPORARY VIEW t AS SELECT 1")
sql("CREATE DATABASE db")
sql("CREATE TABLE t (key INT, value STRING) USING hive")
sql("USE db")
sql("LOAD DATA LOCAL INPATH 'examples/src/main/resources/kv1.txt' INTO TABLE t") // Succeeds
```
With this change, LOAD DATA above fails with the following:
```
org.apache.spark.sql.AnalysisException: t is a temp view not table.; line 1 pos 0
at org.apache.spark.sql.catalyst.analysis.package$AnalysisErrorAt.failAnalysis(package.scala:42)
at org.apache.spark.sql.catalyst.analysis.Analyzer$ResolveTempViews$$anonfun$apply$7.$anonfun$applyOrElse$39(Analyzer.scala:865)
at scala.Option.foreach(Option.scala:407)
```
, which is expected since temporary view is resolved first and LOAD DATA doesn't support a temporary view.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
After this PR, `LOAD DATA ... t` is resolved to a temp view `t` instead of table `db.t` in the above scenario.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Updated existing tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-723318038
**[Test build #130734 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130734/testReport)** for PR 30270 at commit [`4bc60c2`](https://github.com/apache/spark/commit/4bc60c21ffb2f1cabe7f24290bba766f745ca7a7).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-723205417
**[Test build #130734 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130734/testReport)** for PR 30270 at commit [`4bc60c2`](https://github.com/apache/spark/commit/4bc60c21ffb2f1cabe7f24290bba766f745ca7a7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-722970160
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35314/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-723318766
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-724231515
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35408/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-723238576
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-722795386
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35292/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-722795402
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-723052596
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-722980393
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-722775681
**[Test build #130681 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130681/testReport)** for PR 30270 at commit [`070c155`](https://github.com/apache/spark/commit/070c155c24cf66a53f32d2abbc4794010daee50e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-722938527
**[Test build #130693 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130693/testReport)** for PR 30270 at commit [`10e9446`](https://github.com/apache/spark/commit/10e94466a0ea59c873824d3b2cd74c6f68c7445e).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-723238576
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-724462081
thanks, merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-722942122
**[Test build #130704 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130704/testReport)** for PR 30270 at commit [`10e9446`](https://github.com/apache/spark/commit/10e94466a0ea59c873824d3b2cd74c6f68c7445e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] imback82 commented on a change in pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
imback82 commented on a change in pull request #30270:
URL: https://github.com/apache/spark/pull/30270#discussion_r518959583
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/test/TestHive.scala
##########
@@ -496,7 +496,10 @@ private[hive] class TestHiveSparkSession(
def getLoadedTables: collection.mutable.HashSet[String] = sharedState.loadedTables
def loadTestTable(name: String): Unit = {
- if (!sharedState.loadedTables.contains(name)) {
+ // LOAD DATA does not work on temporary views. Since temporary views are resolved first,
+ // skip loading if there exists a temporary view with the given name.
+ if (sessionState.catalog.getTempView(name).isEmpty &&
+ !sharedState.loadedTables.contains(name)) {
// Marks the table as loaded first to prevent infinite mutually recursive table loading.
Review comment:
Note that this `def` is called as follows:
https://github.com/apache/spark/blob/93ad26be01a47fb075310a26188e238d55110098/sql/hive/src/test/scala/org/apache/spark/sql/hive/test/TestHive.scala#L611-L619
Before this PR, it was resolved to a table in the current database, but after this PR, it will be resolved to a temporary view (if exists).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-723225559
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35343/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] imback82 commented on a change in pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
imback82 commented on a change in pull request #30270:
URL: https://github.com/apache/spark/pull/30270#discussion_r520042551
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala
##########
@@ -589,3 +589,15 @@ case class AnalyzeColumn(
"mutually exclusive. Only one of them should be specified.")
override def children: Seq[LogicalPlan] = child :: Nil
}
+
+/**
+ * The logical plan of the LOAD DATA INTO TABLE command that works for v2 catalogs.
Review comment:
I removed all the instances of `that works for v2 catalogs`.
Btw, there are some commands that work only with v1 catalogs - namespace related commands, for example. (this is a commit removing the comments only for commands that work for both v1/v2 catalogs.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-722851838
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130681/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] imback82 commented on a change in pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
imback82 commented on a change in pull request #30270:
URL: https://github.com/apache/spark/pull/30270#discussion_r518501015
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
##########
@@ -312,8 +312,8 @@ class ResolveSessionCatalog(
ignoreIfExists = c.ifNotExists)
}
- case RefreshTable(r @ ResolvedTable(_, _, _: V1Table)) if isSessionCatalog(r.catalog) =>
- RefreshTableCommand(r.identifier.asTableIdentifier)
+ case RefreshTable(ResolvedV1TableIdentifier(ident)) =>
+ RefreshTableCommand(ident.asTableIdentifier)
Review comment:
Note that changes related to `RefreshTable`, `DropTable`, and `ShowTableProperties` are to use the new extractor `ResolvedV1TableIdentifier`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-724338391
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-723205417
**[Test build #130734 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130734/testReport)** for PR 30270 at commit [`4bc60c2`](https://github.com/apache/spark/commit/4bc60c21ffb2f1cabe7f24290bba766f745ca7a7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-724243094
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-722795402
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-722938868
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130693/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-722915879
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35303/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] imback82 commented on a change in pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
imback82 commented on a change in pull request #30270:
URL: https://github.com/apache/spark/pull/30270#discussion_r520047979
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/test/TestHive.scala
##########
@@ -496,7 +496,10 @@ private[hive] class TestHiveSparkSession(
def getLoadedTables: collection.mutable.HashSet[String] = sharedState.loadedTables
def loadTestTable(name: String): Unit = {
- if (!sharedState.loadedTables.contains(name)) {
+ // LOAD DATA does not work on temporary views. Since temporary views are resolved first,
+ // skip loading if there exists a temporary view with the given name.
Review comment:
There are test suites (full list [here](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130704/testReport/)) that use the same name for temporary view and table (for example, `src`) and that those predefined tables will be loaded in this `def`:
https://github.com/apache/spark/blob/8113c88542ee282b510c7e046d64df1761a85d14/sql/hive/src/test/scala/org/apache/spark/sql/hive/test/TestHive.scala#L336-L338
, leading to an exception thrown since `LOAD DATA` doesn't work with temporary views.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-722980393
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-723318766
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-722942122
**[Test build #130704 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130704/testReport)** for PR 30270 at commit [`10e9446`](https://github.com/apache/spark/commit/10e94466a0ea59c873824d3b2cd74c6f68c7445e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-722863596
**[Test build #130693 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130693/testReport)** for PR 30270 at commit [`10e9446`](https://github.com/apache/spark/commit/10e94466a0ea59c873824d3b2cd74c6f68c7445e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-724243094
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-722938861
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #30270:
URL: https://github.com/apache/spark/pull/30270
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-722850992
**[Test build #130681 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130681/testReport)** for PR 30270 at commit [`070c155`](https://github.com/apache/spark/commit/070c155c24cf66a53f32d2abbc4794010daee50e).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class LoadData(`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-723051843
**[Test build #130704 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130704/testReport)** for PR 30270 at commit [`10e9446`](https://github.com/apache/spark/commit/10e94466a0ea59c873824d3b2cd74c6f68c7445e).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-722851806
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-722915893
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-724207837
**[Test build #130799 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130799/testReport)** for PR 30270 at commit [`d01a95e`](https://github.com/apache/spark/commit/d01a95e11896388f0978d6d102c363f3a45c28a7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] imback82 commented on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
imback82 commented on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-722940048
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-724337388
**[Test build #130799 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130799/testReport)** for PR 30270 at commit [`d01a95e`](https://github.com/apache/spark/commit/d01a95e11896388f0978d6d102c363f3a45c28a7).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-724338391
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-722901987
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35303/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-722915893
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-722795409
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35292/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-722980374
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35314/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-723052604
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130704/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-724243076
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35408/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-722787768
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35292/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-722938861
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-723052596
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-722863596
**[Test build #130693 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130693/testReport)** for PR 30270 at commit [`10e9446`](https://github.com/apache/spark/commit/10e94466a0ea59c873824d3b2cd74c6f68c7445e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-722775681
**[Test build #130681 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130681/testReport)** for PR 30270 at commit [`070c155`](https://github.com/apache/spark/commit/070c155c24cf66a53f32d2abbc4794010daee50e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] imback82 commented on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
imback82 commented on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-723329296
@cloud-fan Could you take a look? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-723238557
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35343/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-724207837
**[Test build #130799 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130799/testReport)** for PR 30270 at commit [`d01a95e`](https://github.com/apache/spark/commit/d01a95e11896388f0978d6d102c363f3a45c28a7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #30270:
URL: https://github.com/apache/spark/pull/30270#discussion_r519608729
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/test/TestHive.scala
##########
@@ -496,7 +496,10 @@ private[hive] class TestHiveSparkSession(
def getLoadedTables: collection.mutable.HashSet[String] = sharedState.loadedTables
def loadTestTable(name: String): Unit = {
- if (!sharedState.loadedTables.contains(name)) {
+ // LOAD DATA does not work on temporary views. Since temporary views are resolved first,
+ // skip loading if there exists a temporary view with the given name.
Review comment:
what happens if we don't skip?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30270: [SPARK-33366][SQL] Migrate LOAD DATA command to use UnresolvedTable to resolve the identifier
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30270:
URL: https://github.com/apache/spark/pull/30270#issuecomment-722851806
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org