You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "carloea2 (via GitHub)" <gi...@apache.org> on 2026/08/30 22:22:47 UTC
[PR] fix(amber): ignore blank dashboard keywords [texera]
carloea2 opened a new pull request, #8157:
URL: https://github.com/apache/texera/pull/8157
### What changes were proposed in this PR?
Trim dashboard search keywords before removing empty values so whitespace-only input behaves like an empty search.
Before: blank keyword -> empty full-text predicate
After: blank keyword -> no full-text condition
### Any related issues, documentation, discussions?
Closes #8156
### How was this PR tested?
Updated the regression test to cover spaces and a tab. Existing tests retain coverage for empty input, normal keywords, multiple fields, and both full-text implementations.
`sbt "WorkflowExecutionService / Test / testOnly org.apache.texera.web.resource.dashboard.FulltextSearchQueryUtilsSpec"`
`sbt scalafmtCheckAll`
`sbt "scalafixAll --check"`
Live local checks against the built branch:
| Search input | Before | After |
| --- | --- | --- |
| omitted | 200 | 200 |
| three spaces | 500 | 200 |
| tab | empty full-text predicate | 200 |
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Codex
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(amber): ignore blank dashboard keywords [texera]
Posted by "carloea2 (via GitHub)" <gi...@apache.org>.
carloea2 commented on PR #8157:
URL: https://github.com/apache/texera/pull/8157#issuecomment-5482269910
Ready to merge when you have a chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(amber): ignore blank dashboard keywords [texera]
Posted by "carloea2 (via GitHub)" <gi...@apache.org>.
carloea2 commented on PR #8157:
URL: https://github.com/apache/texera/pull/8157#issuecomment-5498702099
Required checks are green and the release label is gone. The remaining failed backport-preflight is stale. Ready to merge when you have a chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(amber): ignore blank dashboard keywords [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8157:
URL: https://github.com/apache/texera/pull/8157#issuecomment-5471679653
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/8157?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 94.03%. Comparing base ([`98588bf`](https://app.codecov.io/gh/apache/texera/commit/98588bf2ab49aac65ebf002496eb057670e6fc07?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`25e0af9`](https://app.codecov.io/gh/apache/texera/commit/25e0af9925e671815311cc2b644cd57c8c8fbb35?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:white_check_mark: All tests successful. No failed tests found.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #8157 +/- ##
============================================
- Coverage 94.03% 94.03% -0.01%
+ Complexity 4762 4761 -1
============================================
Files 1181 1181
Lines 47877 47877
Branches 5324 5324
============================================
- Hits 45020 45019 -1
- Misses 1433 1434 +1
Partials 1424 1424
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/8157/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/8157/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.00% <ø> (ø)` | | Carriedforward from [98588bf](https://app.codecov.io/gh/apache/texera/commit/98588bf2ab49aac65ebf002496eb057670e6fc07?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/8157/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `99.32% <ø> (ø)` | | Carriedforward from [98588bf](https://app.codecov.io/gh/apache/texera/commit/98588bf2ab49aac65ebf002496eb057670e6fc07?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/8157/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.02% <100.00%> (-0.01%)` | :arrow_down: | |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/8157/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.67% <ø> (ø)` | | Carriedforward from [98588bf](https://app.codecov.io/gh/apache/texera/commit/98588bf2ab49aac65ebf002496eb057670e6fc07?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/8157/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `86.86% <ø> (ø)` | | Carriedforward from [98588bf](https://app.codecov.io/gh/apache/texera/commit/98588bf2ab49aac65ebf002496eb057670e6fc07?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/8157/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.91% <ø> (ø)` | | Carriedforward from [98588bf](https://app.codecov.io/gh/apache/texera/commit/98588bf2ab49aac65ebf002496eb057670e6fc07?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/8157/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.68% <ø> (ø)` | | Carriedforward from [98588bf](https://app.codecov.io/gh/apache/texera/commit/98588bf2ab49aac65ebf002496eb057670e6fc07?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/8157/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `79.31% <ø> (ø)` | | Carriedforward from [98588bf](https://app.codecov.io/gh/apache/texera/commit/98588bf2ab49aac65ebf002496eb057670e6fc07?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/8157/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `98.87% <ø> (ø)` | | Carriedforward from [98588bf](https://app.codecov.io/gh/apache/texera/commit/98588bf2ab49aac65ebf002496eb057670e6fc07?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/8157/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.19% <ø> (ø)` | | Carriedforward from [98588bf](https://app.codecov.io/gh/apache/texera/commit/98588bf2ab49aac65ebf002496eb057670e6fc07?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/8157?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(amber): ignore blank dashboard keywords [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8157:
URL: https://github.com/apache/texera/pull/8157#issuecomment-5471653569
<!-- texera-benchmarks-comment -->
## ⚠️ Benchmark changes need a look
🟢 0 better · 🔴 6 worse · ⚪ 9 noise (<±5%) · 0 without baseline
> Compared against main `98588bf` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
[Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/33339001101)
| | config | throughput | MB/s | latency | max Δ latest / 7d |
|---|---|---:|---:|---:|---:|
| 🔴 | bs=10 sw=10 sl=64 | 348 | 0.212 | 25,857/59,039/59,039 us | 🔴 +53.0% / 🔴 +299.2% |
| 🔴 | bs=100 sw=10 sl=64 | 771 | 0.47 | 127,820/165,578/165,578 us | 🔴 +5.6% / 🔴 +64.0% |
| ⚪ | bs=1000 sw=10 sl=64 | 906 | 0.553 | 1,092,938/1,207,451/1,207,451 us | ⚪ within ±5% / 🔴 +24.8% |
<details><summary>Baseline details</summary>
Latest main `98588bf` from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---:|---:|---:|---:|---:|
| bs=10 sw=10 sl=64 | throughput | 348 tuples/sec | 396 tuples/sec | 844.57 tuples/sec | -12.1% | -58.8% |
| bs=10 sw=10 sl=64 | MB/s | 0.212 MB/s | 0.242 MB/s | 0.515 MB/s | -12.4% | -58.9% |
| bs=10 sw=10 sl=64 | p50 | 25,857 us | 24,328 us | 11,837 us | +6.3% | +118.4% |
| bs=10 sw=10 sl=64 | p95 | 59,039 us | 38,587 us | 14,788 us | +53.0% | +299.2% |
| bs=10 sw=10 sl=64 | p99 | 59,039 us | 38,587 us | 17,651 us | +53.0% | +234.5% |
| bs=100 sw=10 sl=64 | throughput | 771 tuples/sec | 793 tuples/sec | 1,084 tuples/sec | -2.8% | -28.9% |
| bs=100 sw=10 sl=64 | MB/s | 0.47 MB/s | 0.484 MB/s | 0.662 MB/s | -2.9% | -29.0% |
| bs=100 sw=10 sl=64 | p50 | 127,820 us | 121,003 us | 94,505 us | +5.6% | +35.3% |
| bs=100 sw=10 sl=64 | p95 | 165,578 us | 168,630 us | 100,941 us | -1.8% | +64.0% |
| bs=100 sw=10 sl=64 | p99 | 165,578 us | 168,630 us | 108,642 us | -1.8% | +52.4% |
| bs=1000 sw=10 sl=64 | throughput | 906 tuples/sec | 915 tuples/sec | 1,119 tuples/sec | -1.0% | -19.1% |
| bs=1000 sw=10 sl=64 | MB/s | 0.553 MB/s | 0.558 MB/s | 0.683 MB/s | -0.9% | -19.1% |
| bs=1000 sw=10 sl=64 | p50 | 1,092,938 us | 1,099,410 us | 924,404 us | -0.6% | +18.2% |
| bs=1000 sw=10 sl=64 | p95 | 1,207,451 us | 1,158,116 us | 967,785 us | +4.3% | +24.8% |
| bs=1000 sw=10 sl=64 | p99 | 1,207,451 us | 1,158,116 us | 995,630 us | +4.3% | +21.3% |
</details>
<details><summary>Raw CSV</summary>
```csv
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,574.94,200,128000,348,0.212,25857.30,59039.15,59039.15
1,100,10,64,20,2595.28,2000,1280000,771,0.470,127820.30,165577.83,165577.83
2,1000,10,64,20,22066.38,20000,12800000,906,0.553,1092937.65,1207450.50,1207450.50
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(amber): ignore blank dashboard keywords [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8157:
URL: https://github.com/apache/texera/pull/8157#issuecomment-5471624779
<!-- backport-auto-label-report -->
### Backport auto-label report
This `fix:` PR was checked against each actively-supported release branch. `release/*` labels drive the post-merge backport, so add or remove one to change where this fix lands.
| Release branch | Analysis |
| --- | --- |
| ⚠️ `release/v1.3` | Not labeled automatically — none of the files this PR modifies exist on this branch (`amber/src/main/scala/org/apache/texera/web/resource/dashboard/FulltextSearchQueryUtils.scala`, `amber/src/test/scala/org/apache/texera/web/resource/dashboard/FulltextSearchQueryUtilsSpec.scala`). The fix may target code that isn't on this release, or the files were moved/renamed after the branch was cut. **Please check and add `release/v1.3` by hand if this fix should be backported here.** |
| ✅ `release/v1.2` | Change detected on this branch — label added; this fix is queued to backport here. Requested review from @xuang7. |
_[Auto-label run](https://github.com/apache/texera/actions/runs/33338990246)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(amber): ignore blank dashboard keywords [texera]
Posted by "carloea2 (via GitHub)" <gi...@apache.org>.
carloea2 commented on PR #8157:
URL: https://github.com/apache/texera/pull/8157#issuecomment-5543507093
Approved and required checks are green. Ready to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(amber): ignore blank dashboard keywords [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang merged PR #8157:
URL: https://github.com/apache/texera/pull/8157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(amber): ignore blank dashboard keywords [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8157:
URL: https://github.com/apache/texera/pull/8157#issuecomment-5471624540
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@aglinxinyuan`, `@Yicong-Huang`
You can notify them by mentioning `@aglinxinyuan`, `@Yicong-Huang` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(amber): ignore blank dashboard keywords [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on PR #8157:
URL: https://github.com/apache/texera/pull/8157#issuecomment-5483642928
needs @xuang7's approval for 1.2. also there is a polish/nit comment please consider to fix it. thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(amber): ignore blank dashboard keywords [texera]
Posted by "carloea2 (via GitHub)" <gi...@apache.org>.
carloea2 commented on PR #8157:
URL: https://github.com/apache/texera/pull/8157#issuecomment-5483936096
Updated the stale keyword cleanup reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org