You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2021/06/21 18:19:06 UTC

[GitHub] [hadoop] amahussein opened a new pull request #3131: HADOOP-17769. Upgrade JUnit to 4.13.2. fixes TestBlockRecovery

amahussein opened a new pull request #3131:
URL: https://github.com/apache/hadoop/pull/3131


   HADOOP-17769 Upgrade JUnit to 4.13.2
   JUnit 4.13.1 has a bug that is reported in Junit issue-1652 Timeout ThreadGroups should not be destroyed.
   
   The bug has been fixed in Junit-4.13.2
   
   Backporting PR-3130 to branch-2.10
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on pull request #3131: HADOOP-17769. Upgrade JUnit to 4.13.2. fixes TestBlockRecovery

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #3131:
URL: https://github.com/apache/hadoop/pull/3131#issuecomment-865312114


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |  16m  9s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.  |
   ||| _ branch-2.10 Compile Tests _ |
   | +0 :ok: |  mvndep  |   2m 19s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  13m 15s |  branch-2.10 passed  |
   | +1 :green_heart: |  compile  |  14m  2s |  branch-2.10 passed with JDK Azul Systems, Inc.-1.7.0_262-b10  |
   | +1 :green_heart: |  compile  |  12m  1s |  branch-2.10 passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10  |
   | +1 :green_heart: |  mvnsite  |   2m  3s |  branch-2.10 passed  |
   | +1 :green_heart: |  javadoc  |   1m 41s |  branch-2.10 passed with JDK Azul Systems, Inc.-1.7.0_262-b10  |
   | +1 :green_heart: |  javadoc  |   1m 29s |  branch-2.10 passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 20s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 19s |  the patch passed  |
   | +1 :green_heart: |  compile  |  13m 26s |  the patch passed with JDK Azul Systems, Inc.-1.7.0_262-b10  |
   | +1 :green_heart: |  javac  |  13m 26s |  the patch passed  |
   | +1 :green_heart: |  compile  |  12m  1s |  the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10  |
   | +1 :green_heart: |  javac  |  12m  1s |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   2m  1s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  xml  |   0m  6s |  The patch has no ill-formed XML file.  |
   | +1 :green_heart: |  javadoc  |   1m 41s |  the patch passed with JDK Azul Systems, Inc.-1.7.0_262-b10  |
   | +1 :green_heart: |  javadoc  |   1m 31s |  the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 19s |  hadoop-project in the patch passed.  |
   | +1 :green_heart: |  unit  |   1m 11s |  hadoop-yarn-server-timelineservice in the patch passed.  |
   | +1 :green_heart: |  unit  |   0m 30s |  hadoop-yarn-server-timelineservice-hbase-client in the patch passed.  |
   | +1 :green_heart: |  unit  |   7m 32s |  hadoop-yarn-server-timelineservice-hbase-tests in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 43s |  The patch does not generate ASF License warnings.  |
   |  |   | 110m  2s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3131/1/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/3131 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml |
   | uname | Linux 6b5a3c950908 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | branch-2.10 / ab6b568 |
   | Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10 |
   | Multi-JDK versions | /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_262-b10 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10 |
   |  Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3131/1/testReport/ |
   | Max. process+thread count | 732 (vs. ulimit of 5500) |
   | modules | C: hadoop-project hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase/hadoop-yarn-server-timelineservice-hbase-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests U: . |
   | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3131/1/console |
   | versions | git=2.7.4 maven=3.3.9 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] jojochuang commented on pull request #3131: HADOOP-17769. Upgrade JUnit to 4.13.2. fixes TestBlockRecovery

Posted by GitBox <gi...@apache.org>.
jojochuang commented on pull request #3131:
URL: https://github.com/apache/hadoop/pull/3131#issuecomment-866449353


   Oh yeah sorry I wasn't aware this is for branch-2.10. No issue now. +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] amahussein commented on pull request #3131: HADOOP-17769. Upgrade JUnit to 4.13.2. fixes TestBlockRecovery

Posted by GitBox <gi...@apache.org>.
amahussein commented on pull request #3131:
URL: https://github.com/apache/hadoop/pull/3131#issuecomment-866027772


   > Tried the mvn dependency tree on trunk, it looks fine.
   > @jojochuang do you mean this file?
   > https://github.com/apache/hadoop/blob/trunk/licenses-binary/LICENSE-junit.txt
   > 
   > Couldn't find any version mentioned.
   
   +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] ayushtkn merged pull request #3131: HADOOP-17769. Upgrade JUnit to 4.13.2. fixes TestBlockRecovery

Posted by GitBox <gi...@apache.org>.
ayushtkn merged pull request #3131:
URL: https://github.com/apache/hadoop/pull/3131


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on pull request #3131: HADOOP-17769. Upgrade JUnit to 4.13.2. fixes TestBlockRecovery

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #3131:
URL: https://github.com/apache/hadoop/pull/3131#issuecomment-865312114


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |  16m  9s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.  |
   ||| _ branch-2.10 Compile Tests _ |
   | +0 :ok: |  mvndep  |   2m 19s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  13m 15s |  branch-2.10 passed  |
   | +1 :green_heart: |  compile  |  14m  2s |  branch-2.10 passed with JDK Azul Systems, Inc.-1.7.0_262-b10  |
   | +1 :green_heart: |  compile  |  12m  1s |  branch-2.10 passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10  |
   | +1 :green_heart: |  mvnsite  |   2m  3s |  branch-2.10 passed  |
   | +1 :green_heart: |  javadoc  |   1m 41s |  branch-2.10 passed with JDK Azul Systems, Inc.-1.7.0_262-b10  |
   | +1 :green_heart: |  javadoc  |   1m 29s |  branch-2.10 passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 20s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 19s |  the patch passed  |
   | +1 :green_heart: |  compile  |  13m 26s |  the patch passed with JDK Azul Systems, Inc.-1.7.0_262-b10  |
   | +1 :green_heart: |  javac  |  13m 26s |  the patch passed  |
   | +1 :green_heart: |  compile  |  12m  1s |  the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10  |
   | +1 :green_heart: |  javac  |  12m  1s |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   2m  1s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  xml  |   0m  6s |  The patch has no ill-formed XML file.  |
   | +1 :green_heart: |  javadoc  |   1m 41s |  the patch passed with JDK Azul Systems, Inc.-1.7.0_262-b10  |
   | +1 :green_heart: |  javadoc  |   1m 31s |  the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 19s |  hadoop-project in the patch passed.  |
   | +1 :green_heart: |  unit  |   1m 11s |  hadoop-yarn-server-timelineservice in the patch passed.  |
   | +1 :green_heart: |  unit  |   0m 30s |  hadoop-yarn-server-timelineservice-hbase-client in the patch passed.  |
   | +1 :green_heart: |  unit  |   7m 32s |  hadoop-yarn-server-timelineservice-hbase-tests in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 43s |  The patch does not generate ASF License warnings.  |
   |  |   | 110m  2s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3131/1/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/3131 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml |
   | uname | Linux 6b5a3c950908 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | branch-2.10 / ab6b568 |
   | Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10 |
   | Multi-JDK versions | /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_262-b10 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10 |
   |  Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3131/1/testReport/ |
   | Max. process+thread count | 732 (vs. ulimit of 5500) |
   | modules | C: hadoop-project hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase/hadoop-yarn-server-timelineservice-hbase-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests U: . |
   | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3131/1/console |
   | versions | git=2.7.4 maven=3.3.9 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] amahussein commented on pull request #3131: HADOOP-17769. Upgrade JUnit to 4.13.2. fixes TestBlockRecovery

Posted by GitBox <gi...@apache.org>.
amahussein commented on pull request #3131:
URL: https://github.com/apache/hadoop/pull/3131#issuecomment-866871531


   Thanks @jojochuang , @aajisaka , @ayushtkn and @ferhui for the reviews and feedback.
   This PR is ready to be merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] ayushtkn commented on pull request #3131: HADOOP-17769. Upgrade JUnit to 4.13.2. fixes TestBlockRecovery

Posted by GitBox <gi...@apache.org>.
ayushtkn commented on pull request #3131:
URL: https://github.com/apache/hadoop/pull/3131#issuecomment-866893518


   Merged. Thanx Everyone!!!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] aajisaka commented on pull request #3131: HADOOP-17769. Upgrade JUnit to 4.13.2. fixes TestBlockRecovery

Posted by GitBox <gi...@apache.org>.
aajisaka commented on pull request #3131:
URL: https://github.com/apache/hadoop/pull/3131#issuecomment-866439534


   I think the file exists in trunk but not in branch-2.10.
   https://github.com/apache/hadoop/blob/10b79a26fe0677b266acf237e8458e93743424a6/LICENSE-binary#L505


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org