You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/01/31 12:20:00 UTC
[GitHub] [netbeans] singh-akhilesh opened a new pull request #1907:
[NETBEANS-3702 : Fixed hint 'implements all abstract method' for record
interfaces]
singh-akhilesh opened a new pull request #1907: [NETBEANS-3702 : Fixed hint 'implements all abstract method' for record interfaces]
URL: https://github.com/apache/netbeans/pull/1907
https://issues.apache.org/jira/browse/NETBEANS-3702
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] singh-akhilesh commented on issue #1907: [NETBEANS-3702
: Fixed hint 'implements all abstract method' for record interfaces]
Posted by GitBox <gi...@apache.org>.
singh-akhilesh commented on issue #1907: [NETBEANS-3702 : Fixed hint 'implements all abstract method' for record interfaces]
URL: https://github.com/apache/netbeans/pull/1907#issuecomment-581366692
> > is it possible to rebase on your side ? I'm not sure squash and base works.
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] arusinha commented on issue #1907: [NETBEANS-3702 :
Fixed hint 'implements all abstract method' for record interfaces]
Posted by GitBox <gi...@apache.org>.
arusinha commented on issue #1907: [NETBEANS-3702 : Fixed hint 'implements all abstract method' for record interfaces]
URL: https://github.com/apache/netbeans/pull/1907#issuecomment-581366878
👍 , I had verified the fix . It is working fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] singh-akhilesh commented on issue #1907: [NETBEANS-3702
: Fixed hint 'implements all abstract method' for record interfaces]
Posted by GitBox <gi...@apache.org>.
singh-akhilesh commented on issue #1907: [NETBEANS-3702 : Fixed hint 'implements all abstract method' for record interfaces]
URL: https://github.com/apache/netbeans/pull/1907#issuecomment-581365982
> is it possible to rebase on your side ? I'm not sure squash and base works.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on issue #1907: [NETBEANS-3702 :
Fixed hint 'implements all abstract method' for record interfaces]
Posted by GitBox <gi...@apache.org>.
ebarboni commented on issue #1907: [NETBEANS-3702 : Fixed hint 'implements all abstract method' for record interfaces]
URL: https://github.com/apache/netbeans/pull/1907#issuecomment-581385809
thks for rebase effort and @arusinha for review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] singh-akhilesh opened a new pull request #1907:
[NETBEANS-3702 : Fixed hint 'implements all abstract method' for record
interfaces]
Posted by GitBox <gi...@apache.org>.
singh-akhilesh opened a new pull request #1907: [NETBEANS-3702 : Fixed hint 'implements all abstract method' for record interfaces]
URL: https://github.com/apache/netbeans/pull/1907
https://issues.apache.org/jira/browse/NETBEANS-3702
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] singh-akhilesh commented on a change in pull request
#1907: [NETBEANS-3702 : Fixed hint 'implements all abstract method' for
record interfaces]
Posted by GitBox <gi...@apache.org>.
singh-akhilesh commented on a change in pull request #1907: [NETBEANS-3702 : Fixed hint 'implements all abstract method' for record interfaces]
URL: https://github.com/apache/netbeans/pull/1907#discussion_r374029657
##########
File path: java/java.source.base/src/org/netbeans/modules/java/source/save/CasualDiff.java
##########
@@ -3972,7 +3977,7 @@ else if (Kind.VARIABLE == tree.getKind()) {
}
return result;
}
-
+
Review comment:
Indeed..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on a change in pull request #1907:
[NETBEANS-3702 : Fixed hint 'implements all abstract method' for record
interfaces]
Posted by GitBox <gi...@apache.org>.
ebarboni commented on a change in pull request #1907: [NETBEANS-3702 : Fixed hint 'implements all abstract method' for record interfaces]
URL: https://github.com/apache/netbeans/pull/1907#discussion_r374007273
##########
File path: java/java.source.base/src/org/netbeans/modules/java/source/save/CasualDiff.java
##########
@@ -3972,7 +3977,7 @@ else if (Kind.VARIABLE == tree.getKind()) {
}
return result;
}
-
+
Review comment:
Hi can you remove this space added change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni merged pull request #1907: [NETBEANS-3702 :
Fixed hint 'implements all abstract method' for record interfaces]
Posted by GitBox <gi...@apache.org>.
ebarboni merged pull request #1907: [NETBEANS-3702 : Fixed hint 'implements all abstract method' for record interfaces]
URL: https://github.com/apache/netbeans/pull/1907
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] singh-akhilesh closed pull request #1907: [NETBEANS-3702
: Fixed hint 'implements all abstract method' for record interfaces]
Posted by GitBox <gi...@apache.org>.
singh-akhilesh closed pull request #1907: [NETBEANS-3702 : Fixed hint 'implements all abstract method' for record interfaces]
URL: https://github.com/apache/netbeans/pull/1907
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on issue #1907: [NETBEANS-3702 :
Fixed hint 'implements all abstract method' for record interfaces]
Posted by GitBox <gi...@apache.org>.
ebarboni commented on issue #1907: [NETBEANS-3702 : Fixed hint 'implements all abstract method' for record interfaces]
URL: https://github.com/apache/netbeans/pull/1907#issuecomment-581354128
is it possible to rebase on your side ? I'm not sure squash and base works.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] singh-akhilesh commented on a change in pull request
#1907: [NETBEANS-3702 : Fixed hint 'implements all abstract method' for
record interfaces]
Posted by GitBox <gi...@apache.org>.
singh-akhilesh commented on a change in pull request #1907: [NETBEANS-3702 : Fixed hint 'implements all abstract method' for record interfaces]
URL: https://github.com/apache/netbeans/pull/1907#discussion_r374035398
##########
File path: java/java.source.base/src/org/netbeans/modules/java/source/save/CasualDiff.java
##########
@@ -3972,7 +3977,7 @@ else if (Kind.VARIABLE == tree.getKind()) {
}
return result;
}
-
+
Review comment:
comments addressed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists