You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "JiajunBernoulli (via GitHub)" <gi...@apache.org> on 2023/04/22 02:46:02 UTC

[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #3169: [CALCITE-5665] Reducing ineffective matches for MaterializedViewRules and double calculation for RelOptMaterialization's Metadata using cache

JiajunBernoulli commented on code in PR #3169:
URL: https://github.com/apache/calcite/pull/3169#discussion_r1174261079


##########
core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewRule.java:
##########
@@ -231,21 +260,11 @@ protected void perform(RelOptRuleCall call, @Nullable Project topProject, RelNod
           continue;
         }
 
-        // 3.1. View checks before proceeding

Review Comment:
   Code comments are no longer complete:
   3.1 was deleted, but 3.2 was reserved.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org