[GitHub] [incubator-superset] nytai commented on a change in pull request #10035: fix: adds pagination/infinite scroll to owners select on DashboardList and ChartList

[GitBox <gi...@apache.org>]

nytai commented on a change in pull request #10035:
URL: https://github.com/apache/incubator-superset/pull/10035#discussion_r438458291



##########
File path: superset-frontend/spec/javascripts/components/ListView/ListView_spec.jsx
##########
@@ -347,10 +348,6 @@ describe('ListView with new UI filters', () => {
     expect(wrapper.find(ListViewFilters)).toHaveLength(1);
   });
 
-  it('fetched selects if function is provided', () => {

Review comment:
       fetching now happens on select open/click. This is really hard to simulate via enzyme. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org