[GitHub] zhaijack opened a new issue #458: Stats Provider jars not included in "server-bin" package

[gi...@git.apache.org]

zhaijack opened a new issue #458: Stats Provider jars not included in "server-bin" package 
URL: https://github.com/apache/bookkeeper/issues/458
 
 
   **FEATURE REQUEST**
   
   1. Please describe the feature you are requesting.
   Stats Provider jars not included in "server-bin" package, this will cause error for user to use the release binrary. It would be good to provide a "-all" package besides "server-bin" package.
   
   2. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue?
   should-have
   
   3. Provide any additional detail on your proposed use case for this feature.
   
   bk_server.conf contains the configuration of "statsProviderClass", and user could choose provider between PrometheusMetricsProvider, CodahaleMetricsProvider and Twitter finagle/ostrich/science Provider.  But if user set the provider in bk_server.conf,  run bookies it would cause error, becaue current bin package not contains the provider jar:
   ```
   [root@bookkeeper-1 bookkeeper]# vi conf/bk_server.conf 
   [root@bookkeeper-1 bookkeeper]# bookkeeper bookie
   JMX enabled by default
   2017-08-22 01:26:50,525 - INFO  - [main:BookieServer@301] - Using configuration file /opt/bookkeeper/conf/bk_server.conf
   2017-08-22 01:26:50,535 - INFO  - [main:BookieServer@410] - Hello, I'm your bookie, listening on port 3181. ZKServers are on test_zookeeper:2181. Journals are in [/data/bookkeeper/journal]. Ledgers are stored in /data/bookkeeper/ledgers.
   2017-08-22 01:26:50,538 - ERROR - [main:BookieServer@435] - Exception running bookie server : 
   org.apache.commons.configuration.ConfigurationException: org.apache.commons.configuration.ConfigurationException: java.lang.ClassNotFoundException: org.apache.bookkeeper.stats.CodahaleMetricsProvider
   	at org.apache.bookkeeper.util.ReflectionUtils.getClass(ReflectionUtils.java:102)
   	at org.apache.bookkeeper.conf.ServerConfiguration.getStatsProviderClass(ServerConfiguration.java:1972)
   	at org.apache.bookkeeper.proto.BookieServer.main(BookieServer.java:414)
   Caused by: org.apache.commons.configuration.ConfigurationException: java.lang.ClassNotFoundException: org.apache.bookkeeper.stats.CodahaleMetricsProvider
   	at org.apache.bookkeeper.util.ReflectionUtils.getClass(ReflectionUtils.java:63)
   	at org.apache.bookkeeper.util.ReflectionUtils.getClass(ReflectionUtils.java:93)
   	... 2 more
   Caused by: java.lang.ClassNotFoundException: org.apache.bookkeeper.stats.CodahaleMetricsProvider
   	at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
   	at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
   	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:335)
   	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
   	at java.lang.Class.forName0(Native Method)
   	at java.lang.Class.forName(Class.java:348)
   	at org.apache.bookkeeper.util.ReflectionUtils.getClass(ReflectionUtils.java:61)
   	... 3 more
   ```
   
   This issue is to track the supporting to fix this error.
   
   4. Sub task:
   - [ ] Make Prometheus provider the default in bk_server.conf, 
   - [ ] Include all stats providers in a -all package,
   - [ ] Change docker image for this supporting work.
   - [ ] If user use their own stats provider, write a document on how to use it.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services