You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/07/21 08:28:38 UTC
[GitHub] [cloudstack-kubernetes-provider] davidjumani opened a new pull request, #41: Allow case insensitive vm names while creating lb rules
davidjumani opened a new pull request, #41:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/41
In kubernetes, node names are in lower case but a VM can have an upper case name in cloudstack
This can cause issues mapping kuberenetes nodes to cloudstack VMs
Fixes this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on pull request #41: Allow case insensitive vm names while creating lb rules
Posted by "davidjumani (via GitHub)" <gi...@apache.org>.
davidjumani commented on PR #41:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/41#issuecomment-1420574877
My bad @rohityadavcloud I had tested this myself and verified the fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] rohityadavcloud commented on pull request #41: Allow case insensitive vm names while creating lb rules
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #41:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/41#issuecomment-1415068946
LGTM @davidjumani what do we need to merge this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] kiwiflyer commented on pull request #41: Allow case insensitive vm names while creating lb rules
Posted by "kiwiflyer (via GitHub)" <gi...@apache.org>.
kiwiflyer commented on PR #41:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/41#issuecomment-1413932723
> @kiwiflyer cloudstack-kubernetes-provider is a standalone project, which has different release cycle as cloudstack
Got it, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on pull request #41: Allow case insensitive vm names while creating lb rules
Posted by "davidjumani (via GitHub)" <gi...@apache.org>.
davidjumani commented on PR #41:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/41#issuecomment-1420194318
Just click the merge button :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] kiwiflyer commented on pull request #41: Allow case insensitive vm names while creating lb rules
Posted by "kiwiflyer (via GitHub)" <gi...@apache.org>.
kiwiflyer commented on PR #41:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/41#issuecomment-1413919275
@DaanHoogland Is it too late to pull this in for 4.18?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] rohityadavcloud commented on pull request #41: Allow case insensitive vm names while creating lb rules
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #41:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/41#issuecomment-1420328483
I meant to say, in terms of testing and review @davidjumani I'll merge this however as changes make sense to me and Build has passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] weizhouapache commented on pull request #41: Allow case insensitive vm names while creating lb rules
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #41:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/41#issuecomment-1413923310
@kiwiflyer
cloudstack-kubernetes-provider is a standalone project, which has different release cycle as cloudstack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] rohityadavcloud closed pull request #41: Allow case insensitive vm names while creating lb rules
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud closed pull request #41: Allow case insensitive vm names while creating lb rules
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/41
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] DaanHoogland closed pull request #41: Allow case insensitive vm names while creating lb rules
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland closed pull request #41: Allow case insensitive vm names while creating lb rules
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/41
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] rohityadavcloud merged pull request #41: Allow case insensitive vm names while creating lb rules
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud merged PR #41:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/41
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org