You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/11/15 16:24:51 UTC

[GitHub] [pinot] richardstartin commented on a change in pull request #7768: Indicate QuickStart types for invalid/missing type

richardstartin commented on a change in pull request #7768:
URL: https://github.com/apache/pinot/pull/7768#discussion_r749485918



##########
File path: pinot-tools/src/main/java/org/apache/pinot/tools/AuthQuickstart.java
##########
@@ -19,12 +19,17 @@
 package org.apache.pinot.tools;
 
 import java.util.HashMap;
+import java.util.List;
 import java.util.Map;
 import org.apache.pinot.core.auth.BasicAuthUtils;
 import org.apache.pinot.spi.plugin.PluginManager;
 
 
 public class AuthQuickstart extends Quickstart {
+  @Override
+  public List<String> types() {
+    return List.of("AUTH");

Review comment:
       We need to be JDK8 source compatible - `Collections.singletonList("AUTH")` would do the trick.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org