You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by fa...@apache.org on 2022/12/12 18:14:49 UTC
svn commit: r1905938 - in /poi/trunk: poi-examples/src/main/java/org/apache/poi/examples/ss/html/ poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/ poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/ poi/src/test/java/org/apache/poi/hssf/usermo...
Author: fanningpj
Date: Mon Dec 12 18:14:49 2022
New Revision: 1905938
URL: http://svn.apache.org/viewvc?rev=1905938&view=rev
Log:
remove unnecessary short casts for getCellStyleAt
Modified:
poi/trunk/poi-examples/src/main/java/org/apache/poi/examples/ss/html/ToHtml.java
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFSheet.java
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFBugs.java
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFCellStyle.java
poi/trunk/poi/src/test/java/org/apache/poi/hssf/usermodel/TestBugs.java
poi/trunk/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestCell.java
Modified: poi/trunk/poi-examples/src/main/java/org/apache/poi/examples/ss/html/ToHtml.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi-examples/src/main/java/org/apache/poi/examples/ss/html/ToHtml.java?rev=1905938&r1=1905937&r2=1905938&view=diff
==============================================================================
--- poi/trunk/poi-examples/src/main/java/org/apache/poi/examples/ss/html/ToHtml.java (original)
+++ poi/trunk/poi-examples/src/main/java/org/apache/poi/examples/ss/html/ToHtml.java Mon Dec 12 18:14:49 2022
@@ -320,7 +320,7 @@ public final class ToHtml {
private String styleName(CellStyle style) {
if (style == null) {
- style = wb.getCellStyleAt((short) 0);
+ style = wb.getCellStyleAt(0);
}
StringBuilder sb = new StringBuilder();
try (Formatter fmt = new Formatter(sb, Locale.ROOT)) {
Modified: poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFSheet.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFSheet.java?rev=1905938&r1=1905937&r2=1905938&view=diff
==============================================================================
--- poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFSheet.java (original)
+++ poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFSheet.java Mon Dec 12 18:14:49 2022
@@ -989,7 +989,7 @@ public class XSSFSheet extends POIXMLDoc
@Override
public CellStyle getColumnStyle(int column) {
int idx = columnHelper.getColDefaultStyle(column);
- return getWorkbook().getCellStyleAt((short)(idx == -1 ? 0 : idx));
+ return getWorkbook().getCellStyleAt(idx == -1 ? 0 : idx);
}
/**
Modified: poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFBugs.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFBugs.java?rev=1905938&r1=1905937&r2=1905938&view=diff
==============================================================================
--- poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFBugs.java (original)
+++ poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFBugs.java Mon Dec 12 18:14:49 2022
@@ -1094,7 +1094,7 @@ public final class TestXSSFBugs extends
try (XSSFWorkbook wb = new XSSFWorkbook()) {
XSSFSheet s = wb.createSheet();
- CellStyle defaultStyle = wb.getCellStyleAt((short) 0);
+ CellStyle defaultStyle = wb.getCellStyleAt(0);
assertEquals(0, defaultStyle.getIndex());
CellStyle blueStyle = wb.createCellStyle();
Modified: poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFCellStyle.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFCellStyle.java?rev=1905938&r1=1905937&r2=1905938&view=diff
==============================================================================
--- poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFCellStyle.java (original)
+++ poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFCellStyle.java Mon Dec 12 18:14:49 2022
@@ -597,7 +597,7 @@ class TestXSSFCellStyle {
assertEquals(1, wb.getNumCellStyles());
assertEquals(2, styles.getFills().size());
- XSSFCellStyle defaultStyle = wb.getCellStyleAt((short)0);
+ XSSFCellStyle defaultStyle = wb.getCellStyleAt(0);
assertEquals(IndexedColors.AUTOMATIC.getIndex(), defaultStyle.getFillForegroundColor());
assertNull(defaultStyle.getFillForegroundXSSFColor());
assertEquals(FillPatternType.NO_FILL, defaultStyle.getFillPattern());
Modified: poi/trunk/poi/src/test/java/org/apache/poi/hssf/usermodel/TestBugs.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi/src/test/java/org/apache/poi/hssf/usermodel/TestBugs.java?rev=1905938&r1=1905937&r2=1905938&view=diff
==============================================================================
--- poi/trunk/poi/src/test/java/org/apache/poi/hssf/usermodel/TestBugs.java (original)
+++ poi/trunk/poi/src/test/java/org/apache/poi/hssf/usermodel/TestBugs.java Mon Dec 12 18:14:49 2022
@@ -1541,9 +1541,9 @@ final class TestBugs extends BaseTestBug
// Write out and read back
try (HSSFWorkbook wb2 = writeOutAndReadBack(wb1)) {
// Re-check
- assertEquals("Testing", wb2.getCellStyleAt((short) 21).getUserStyleName());
- assertEquals("Testing 2", wb2.getCellStyleAt((short) 22).getUserStyleName());
- assertEquals("Testing 3", wb2.getCellStyleAt((short) 23).getUserStyleName());
+ assertEquals("Testing", wb2.getCellStyleAt(21).getUserStyleName());
+ assertEquals("Testing 2", wb2.getCellStyleAt(22).getUserStyleName());
+ assertEquals("Testing 3", wb2.getCellStyleAt(23).getUserStyleName());
}
}
}
Modified: poi/trunk/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestCell.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestCell.java?rev=1905938&r1=1905937&r2=1905938&view=diff
==============================================================================
--- poi/trunk/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestCell.java (original)
+++ poi/trunk/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestCell.java Mon Dec 12 18:14:49 2022
@@ -844,7 +844,7 @@ public abstract class BaseTestCell {
Cell cell = row.createCell(0);
// different default style indexes for HSSF and XSSF/SXSSF
- CellStyle defaultStyle = wb.getCellStyleAt(wb instanceof HSSFWorkbook ? (short) 15 : (short) 0);
+ CellStyle defaultStyle = wb.getCellStyleAt(wb instanceof HSSFWorkbook ? 15 : 0);
// Starts out with the default style
assertEquals(defaultStyle, cell.getCellStyle());
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org