You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Philip Martin <ph...@codematters.co.uk> on 2003/11/12 22:09:31 UTC
Re: svn commit: rev 7712 -
branches/issue-1429-dev/subversion/mod_dav_svn
kfogel@tigris.org writes:
> Author: kfogel
> Date: Wed Nov 12 11:05:55 2003
> New Revision: 7712
>
> Modified:
> branches/issue-1429-dev/subversion/mod_dav_svn/update.c
> Log:
> With Mike, fix bug in receiving empty files:
>
> * subversion/mod_dav_svn/update.c
> (window_handler): In send-all mode, still open and close the txdelta
> tags even if the file is empty.
Was this a regression test failure? (What I'm really asking is do we
need an empty file regression test...)
--
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: rev 7712 - branches/issue-1429-dev/subversion/mod_dav_svn
Posted by kf...@collab.net.
Philip Martin <ph...@codematters.co.uk> writes:
> > With Mike, fix bug in receiving empty files:
> >
> > * subversion/mod_dav_svn/update.c
> > (window_handler): In send-all mode, still open and close the txdelta
> > tags even if the file is empty.
>
> Was this a regression test failure? (What I'm really asking is do we
> need an empty file regression test...)
It was not a regression test failure, we found it independently.
I don't know if there is a regression test for checking out a
directory empty files or not. There certainly should be, yes :-).
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: rev 7712 -
branches/issue-1429-dev/subversion/mod_dav_svn
Posted by Ben Collins-Sussman <su...@collab.net>.
On Wed, 2003-11-12 at 16:09, Philip Martin wrote:
> kfogel@tigris.org writes:
>
> > Author: kfogel
> > Date: Wed Nov 12 11:05:55 2003
> > New Revision: 7712
> >
> > Modified:
> > branches/issue-1429-dev/subversion/mod_dav_svn/update.c
> > Log:
> > With Mike, fix bug in receiving empty files:
> >
> > * subversion/mod_dav_svn/update.c
> > (window_handler): In send-all mode, still open and close the txdelta
> > tags even if the file is empty.
>
> Was this a regression test failure? (What I'm really asking is do we
> need an empty file regression test...)
Nope, not a regression test failure.
In the new checkout/update REPORT responses, we're now sending txdeltas
inline, within <txdelta> tags. The bug was simple: if the file's
contents were empty, mod_dav_svn wasn't sending the <txdelta> tag at
all, which ultimately caused the update_editor's apply_txdelta() to
never be invoked, not even with an empty-window.
This never happened with the 'old style' REPORT responses, since in that
case ra_dav is doing an explicit GET on each file to drive
apply_txdelta().
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org