[GitHub] [airflow] mcw0933 commented on issue #5297: AIRFLOW-2143 - Fix TaskTries graph counts off-by-1

[GitBox <gi...@apache.org>]

mcw0933 commented on issue #5297: AIRFLOW-2143 - Fix TaskTries graph counts off-by-1
URL: https://github.com/apache/airflow/pull/5297#issuecomment-546650117
 
 
   Thanks for the ping @OmerJog.  @ashb - yes, the Gantt view did have logic that benefits from using this property instead.  So did a couple other locations dealing with non-running / no-longer-running tasks in taskinstance itself.  
   
   I hadn't intended for this to be such an invasive change, I really only wanted to affect the UI labels on TaskTries.  I use the TaskTries graph a lot in my work to understand misbehaving tasks in my data pipelines, and the off-by-1 is an annoyance.
   
   That said, I do feel like the +1 behavior in `try_number` is confusing, and it's clear other committers have had to try to work around it.  I would totally understand if any more experienced maintainers would prefer a more thorough refactor of how that property works, or when/whether the `prev_attempted_tries` property should be used instead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services