You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/05/24 07:12:19 UTC
[GitHub] [ozone] kaijchen commented on a diff in pull request #3233: HDDS-6476. Support FSO in OMOpenKeysDeleteRequest and Response
kaijchen commented on code in PR #3233:
URL: https://github.com/apache/ozone/pull/3233#discussion_r880137908
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMOpenKeysDeleteRequest.java:
##########
@@ -97,7 +97,7 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
}
omClientResponse = new OMOpenKeysDeleteResponse(omResponse.build(),
- deletedOpenKeys, ozoneManager.isRatisEnabled());
+ deletedOpenKeys, ozoneManager.isRatisEnabled(), getBucketLayout());
Review Comment:
The `BucketLayout` here is only used to indicate which table is the open keys from.
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMOpenKeysDeleteRequest.java:
##########
@@ -97,7 +97,7 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
}
omClientResponse = new OMOpenKeysDeleteResponse(omResponse.build(),
- deletedOpenKeys, ozoneManager.isRatisEnabled());
+ deletedOpenKeys, ozoneManager.isRatisEnabled(), getBucketLayout());
Review Comment:
The `BucketLayout` here is only used to indicate which table the open keys are from.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org