[GitHub] spark pull request #16825: [SPARK-19481][REPL][maven]Avoid to leak SparkCont...

[davies <gi...@git.apache.org>]

Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16825#discussion_r100206125
  
    --- Diff: repl/src/main/scala/org/apache/spark/repl/Signaling.scala ---
    @@ -28,15 +28,17 @@ private[repl] object Signaling extends Logging {
        * when no jobs are currently running.
        * This makes it possible to interrupt a running shell job by pressing Ctrl+C.
        */
    -  def cancelOnInterrupt(ctx: SparkContext): Unit = SignalUtils.register("INT") {
    -    if (!ctx.statusTracker.getActiveJobIds().isEmpty) {
    -      logWarning("Cancelling all active jobs, this can take a while. " +
    -        "Press Ctrl+C again to exit now.")
    -      ctx.cancelAllJobs()
    -      true
    -    } else {
    -      false
    -    }
    +  def cancelOnInterrupt(): Unit = SignalUtils.register("INT") {
    --- End diff --
    
    Who is using this one? Is this a breaking change?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org