You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/09/27 13:40:37 UTC
[GitHub] [tvm] gigiblender opened a new pull request, #12915: [ci] Assert some tests are not skipped in the CI.
gigiblender opened a new pull request, #12915:
URL: https://github.com/apache/tvm/pull/12915
In this PR, the skipped tests script will also check if tests in the `required_tests_to_run.json` have not been skipped. If there were skipped tests, they will be added to the returned comment.
I am not entirely sure where it's best to place the `required_tests_to_run` file so I left it in `tvm/ci/scripts/`. I am happy to take suggestions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on a diff in pull request #12915: [ci] Assert some tests are not skipped in the CI
Posted by GitBox <gi...@apache.org>.
driazati commented on code in PR #12915:
URL: https://github.com/apache/tvm/pull/12915#discussion_r1014431148
##########
ci/scripts/github_skipped_tests_comment.py:
##########
@@ -114,18 +137,20 @@ def build_comment(
if common_main_build["state"] != "success":
return f"Unable to run tests bot because main failed to pass CI at {common_commit_sha}."
- if len(skipped_list) == 0:
- return f"No additional skipped tests found in this branch for commit {commit_sha}."
+ text = build_diff_comment_with_main(common_commit_sha, skipped_list, commit_sha)
+
+ if len(additional_skipped_list) != 0:
+ text += "\n"
+ text += (
+ f"Additional tests that were skipped in the CI build and present in the `required_tests_to_run` file:"
Review Comment:
```suggestion
f"Additional tests that were skipped in the CI build and present in the [`required_tests_to_run`](https://github.com/apache/tvm/blob/main/ci/scripts/required_tests_to_run.json) file:"
```
##########
ci/scripts/github_skipped_tests_comment.py:
##########
@@ -195,10 +221,43 @@ def get_skipped_tests_comment(
if len(skipped_list) == 0:
logging.info("No skipped tests found.")
+ if not is_dry_run:
+ current_file = abspath(inspect.getsourcefile(lambda: 0))
Review Comment:
is this different from `pathlib.Path(__file__).resolve()`?
##########
ci/scripts/github_skipped_tests_comment.py:
##########
@@ -195,10 +221,43 @@ def get_skipped_tests_comment(
if len(skipped_list) == 0:
logging.info("No skipped tests found.")
+ if not is_dry_run:
+ current_file = abspath(inspect.getsourcefile(lambda: 0))
+ additional_tests_to_check_file = (
Review Comment:
nit: use pathlib to clean stuff up, e.g. `Path(current_file).parent / "required_tests_to_run.json"`
##########
tests/python/ci/test_ci.py:
##########
@@ -176,6 +276,10 @@ def write_xml_file(root_dir, xml_file, xml_content):
write_xml_file(pr_test_report_dir, pr_xml_file, pr_xml_content)
main_test_report_dir = Path(git.cwd) / "main-reports"
write_xml_file(main_test_report_dir, main_xml_file, main_xml_content)
+ if os.path.exists("required_tests_to_run.json"):
+ os.remove("required_tests_to_run.json")
+ with open("required_tests_to_run.json", "w") as f:
+ f.write(additional_tests_to_check)
Review Comment:
this should all happen inside a temp dir to not pollute the repo checkout
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati merged pull request #12915: [ci] Assert some tests are not skipped in the CI
Posted by GitBox <gi...@apache.org>.
driazati merged PR #12915:
URL: https://github.com/apache/tvm/pull/12915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gigiblender commented on pull request #12915: [ci] Assert some tests are not skipped in the CI
Posted by GitBox <gi...@apache.org>.
gigiblender commented on PR #12915:
URL: https://github.com/apache/tvm/pull/12915#issuecomment-1301957809
cc @driazati @areusch for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #12915: [ci] Assert some tests are not skipped in the CI
Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #12915:
URL: https://github.com/apache/tvm/pull/12915#issuecomment-1301939534
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-docs-start-->
* Built docs for commit b1eb3bbf039a013dce1fd5ddf94ad389eef7edea can be found [here](https://pr-docs.tlcpack.ai/PR-12915/8/docs/index.html).<!--bot-comment-docs-end--><!--bot-comment-runtime-start-->
* This PR had no significant effect on [CI runtime](https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-12915/8/pipeline): -10.39% (172.14m -> 154.24m)<!--bot-comment-runtime-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org