You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2015/04/14 22:53:01 UTC
Review Request 33189: RANGER-396: fix for failure in updating
service.policyVersion
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33189/
-----------------------------------------------------------
Review request for ranger, Don Bosco Durai, dilli dorai, Gautam Borad, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-396
https://issues.apache.org/jira/browse/RANGER-396
Repository: ranger
Description
-------
Instead of updating RangerService object as a whole (which requires data from x_service and x_service_config_map tables), update is now done only to x_service table - this is more efficient and also wouldn't require validation of configs (as these are not changed).
Also updated the method used by the plugins to look for policy changes in a service to read only at x_service table content.
Diffs
-----
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 239723a
Diff: https://reviews.apache.org/r/33189/diff/
Testing
-------
Verified that policy create/update/delete complete successfully without reporting errors. Verified that policy download by the plugins work as expected.
Thanks,
Madhan Neethiraj
Re: Review Request 33189: RANGER-396: fix for failure in updating
service.policyVersion
Posted by Selvamohan Neethiraj <sn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33189/#review80106
-----------------------------------------------------------
Ship it!
Ship It!
- Selvamohan Neethiraj
On April 14, 2015, 4:53 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33189/
> -----------------------------------------------------------
>
> (Updated April 14, 2015, 4:53 p.m.)
>
>
> Review request for ranger, Don Bosco Durai, dilli dorai, Gautam Borad, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-396
> https://issues.apache.org/jira/browse/RANGER-396
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Instead of updating RangerService object as a whole (which requires data from x_service and x_service_config_map tables), update is now done only to x_service table - this is more efficient and also wouldn't require validation of configs (as these are not changed).
>
> Also updated the method used by the plugins to look for policy changes in a service to read only at x_service table content.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 239723a
>
> Diff: https://reviews.apache.org/r/33189/diff/
>
>
> Testing
> -------
>
> Verified that policy create/update/delete complete successfully without reporting errors. Verified that policy download by the plugins work as expected.
>
>
> Thanks,
>
> Madhan Neethiraj
>
>