You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2022/07/18 10:06:47 UTC
[GitHub] [hadoop] steveloughran opened a new pull request, #4580: HADOOP-13386. Upgrade Avro to 1.9.2 (#3990)
steveloughran opened a new pull request, #4580:
URL: https://github.com/apache/hadoop/pull/4580
#3990 for 3.3.4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran closed pull request #4580: HADOOP-13386. Upgrade Avro to 1.9.2 (#3990)
Posted by GitBox <gi...@apache.org>.
steveloughran closed pull request #4580: HADOOP-13386. Upgrade Avro to 1.9.2 (#3990)
URL: https://github.com/apache/hadoop/pull/4580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on pull request #4580: HADOOP-13386. Upgrade Avro to 1.9.2 (#3990)
Posted by GitBox <gi...@apache.org>.
steveloughran commented on PR #4580:
URL: https://github.com/apache/hadoop/pull/4580#issuecomment-1187919052
thanks for that. i was wondering about the risk of this one as far as code compilation goes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #4580: HADOOP-13386. Upgrade Avro to 1.9.2 (#3990)
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on PR #4580:
URL: https://github.com/apache/hadoop/pull/4580#issuecomment-1188551556
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 10m 18s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | shelldocs | 0m 0s | | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 2 new or modified test files. |
|||| _ branch-3.3.4 Compile Tests _ |
| +0 :ok: | mvndep | 4m 47s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 34m 2s | | branch-3.3.4 passed |
| +1 :green_heart: | compile | 18m 53s | | branch-3.3.4 passed |
| +1 :green_heart: | checkstyle | 3m 14s | | branch-3.3.4 passed |
| +1 :green_heart: | mvnsite | 25m 25s | | branch-3.3.4 passed |
| +1 :green_heart: | javadoc | 8m 6s | | branch-3.3.4 passed |
| +0 :ok: | spotbugs | 0m 27s | | branch/hadoop-project no spotbugs output file (spotbugsXml.xml) |
| +1 :green_heart: | shadedclient | 26m 17s | | branch has no errors when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 29s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 28m 54s | | the patch passed |
| +1 :green_heart: | compile | 18m 18s | | the patch passed |
| -1 :x: | javac | 18m 18s | [/results-compile-javac-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4580/1/artifact/out/results-compile-javac-root.txt) | root generated 1 new + 1971 unchanged - 2 fixed = 1972 total (was 1973) |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 3m 9s | | the patch passed |
| +1 :green_heart: | mvnsite | 21m 35s | | the patch passed |
| +1 :green_heart: | shellcheck | 0m 0s | | No new issues. |
| +1 :green_heart: | xml | 0m 7s | | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 7m 52s | | the patch passed |
| +0 :ok: | spotbugs | 0m 26s | | hadoop-project has no data from spotbugs |
| +1 :green_heart: | shadedclient | 59m 29s | | patch has no errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 701m 17s | [/patch-unit-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4580/1/artifact/out/patch-unit-root.txt) | root in the patch passed. |
| +1 :green_heart: | asflicense | 2m 1s | | The patch does not generate ASF License warnings. |
| | | 1035m 40s | | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.yarn.csi.client.TestCsiClient |
| | hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerOvercommit |
| | hadoop.yarn.applications.distributedshell.TestDistributedShell |
| | hadoop.security.TestRaceWhenRelogin |
| | hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes |
| | hadoop.yarn.sls.appmaster.TestAMSimulator |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4580/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/4580 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell xml shellcheck shelldocs |
| uname | Linux fe8b40cd3ff5 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | branch-3.3.4 / 707db40592c1bc4b389dd643514034cf5418b7ba |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4580/1/testReport/ |
| Max. process+thread count | 2142 (vs. ulimit of 5500) |
| modules | C: hadoop-project hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests hadoop-mapreduce-project . U: . |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4580/1/console |
| versions | git=2.17.1 maven=3.6.0 shellcheck=0.4.6 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] xkrogen commented on pull request #4580: HADOOP-13386. Upgrade Avro to 1.9.2 (#3990)
Posted by GitBox <gi...@apache.org>.
xkrogen commented on PR #4580:
URL: https://github.com/apache/hadoop/pull/4580#issuecomment-1187715602
I'm -1 on this. Avro versions follow the following convention (refer to [this comment](https://github.com/apache/avro/pull/1333#issuecomment-930355417) and [this dev list thread](https://lists.apache.org/thread/6ppm20v5602w9nqz0nk5qz7mxnnt2tsw)):
```
<data compatibility> . <major library version> . <minor library version>
```
So while going from 1.7.7 to 1.9.2 may look like a minor version upgrade at first glance, it's actually an upgrade of 2 major versions (7 -> 9). This is way too big of a change to include into a patch release of Hadoop.
This isn't just a theoretical problem; Avro major version upgrades really do bring in breaking changes. We (LinkedIn) maintain [an entire library devoted to smoothing over such breaking changes](https://github.com/linkedin/avro-util/tree/master/helper). Speaking from personal experience, without such a compatibility layer, a major version upgrade of Avro will cause many downstreams to break.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org