You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/01/28 22:05:25 UTC
[GitHub] [camel-quarkus] erayerdem opened a new pull request #3505: Patch 2
erayerdem opened a new pull request #3505:
URL: https://github.com/apache/camel-quarkus/pull/3505
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #3505: Patch 2
Posted by GitBox <gi...@apache.org>.
aldettinger commented on pull request #3505:
URL: https://github.com/apache/camel-quarkus/pull/3505#issuecomment-1036399271
@erayerdem Many thanks for contributions. The freemarker configuration [comes from quarkus-freemarker](https://github.com/apache/camel-quarkus/blob/main/extensions/freemarker/runtime/src/main/doc/configuration.adoc#quarkiverse-freemarker-and-its-configuration). As such, one should use the `quarkus.freemarker.includes` property to include the templates as shown in [integration tests](https://github.com/apache/camel-quarkus/blob/main/integration-tests/freemarker/src/main/resources/application.properties).
So, the section dealing with including native resources in camel-quarkus-freemarker documentation may not be needed anymore. quarkus-freemarker [is embedding all templates in the native executable](https://github.com/quarkiverse/quarkus-freemarker/blob/master/deployment/src/main/java/io/quarkiverse/freemarker/deployment/FreemarkerProcessor.java#L106).
That said, are you ok with closing this PR in favor of #3545 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] erayerdem commented on pull request #3505: Patch 2
Posted by GitBox <gi...@apache.org>.
erayerdem commented on pull request #3505:
URL: https://github.com/apache/camel-quarkus/pull/3505#issuecomment-1038072126
Yes you can thanks 😀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] erayerdem commented on pull request #3505: Patch 2
Posted by GitBox <gi...@apache.org>.
erayerdem commented on pull request #3505:
URL: https://github.com/apache/camel-quarkus/pull/3505#issuecomment-1038072126
Yes you can thanks 😀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #3505: Patch 2
Posted by GitBox <gi...@apache.org>.
aldettinger commented on pull request #3505:
URL: https://github.com/apache/camel-quarkus/pull/3505#issuecomment-1038783161
Closing in favor of https://github.com/apache/camel-quarkus/pull/3545.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger closed pull request #3505: Patch 2
Posted by GitBox <gi...@apache.org>.
aldettinger closed pull request #3505:
URL: https://github.com/apache/camel-quarkus/pull/3505
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org