You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2021/12/14 17:22:11 UTC
[GitHub] [sling-site] kwin commented on a change in pull request #75: Update models docs documenting any-visibility constructors
kwin commented on a change in pull request #75:
URL: https://github.com/apache/sling-site/pull/75#discussion_r768884960
##########
File path: src/main/jbake/content/documentation/bundles/models.md
##########
@@ -55,6 +57,35 @@ Constructor injection is also supported (as of Sling Models 1.1.0):
Because the name of a constructor argument parameter cannot be detected via the Java Reflection API a `@Named` annotation is mandatory for injectors that require a name for resolving the injection.
+Constructors may use any visibility modifier (as of Sling Models 1.5.0):
Review comment:
```suggestion
Constructors may use any visibility modifier (as of [Sling Models 1.5.0](https://issues.apache.org/jira/browse/SLING-8069)):
```
##########
File path: src/main/jbake/content/documentation/bundles/models.md
##########
@@ -55,6 +57,35 @@ Constructor injection is also supported (as of Sling Models 1.1.0):
Because the name of a constructor argument parameter cannot be detected via the Java Reflection API a `@Named` annotation is mandatory for injectors that require a name for resolving the injection.
+Constructors may use any visibility modifier (as of Sling Models 1.5.0):
Review comment:
Shouldn't we mention fields and methods here as well for completion? IMHO those never had any restrictions in terms of visibility....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org