You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/16 20:11:53 UTC
[GitHub] [arrow] nevi-me opened a new pull request #9216: ARROW-11271: [Rust] [Parquet] Fix parquet list schema null conversion
nevi-me opened a new pull request #9216:
URL: https://github.com/apache/arrow/pull/9216
Please see the JIRA for the issue details https://issues.apache.org/jira/browse/ARROW-11271.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #9216: ARROW-11271: [Rust] [Parquet] Fix parquet list schema null conversion
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #9216:
URL: https://github.com/apache/arrow/pull/9216#issuecomment-761757761
> This is not as severe as i thought, so it's fine if it doesn't make it to 3.0.0 @alamb @kszucs
We have packaging issues so we probably need to create another release candidate, so we can include this patch as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me commented on pull request #9216: ARROW-11271: [Rust] [Parquet] Fix parquet list schema null conversion
Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #9216:
URL: https://github.com/apache/arrow/pull/9216#issuecomment-761625443
This is not as severe as i thought, so it's fine if it doesn't make it to 3.0.0 @alamb @kszucs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs edited a comment on pull request #9216: ARROW-11271: [Rust] [Parquet] Fix parquet list schema null conversion
Posted by GitBox <gi...@apache.org>.
kszucs edited a comment on pull request #9216:
URL: https://github.com/apache/arrow/pull/9216#issuecomment-761757761
> This is not as severe as i thought, so it's fine if it doesn't make it to 3.0.0 @alamb @kszucs
We have packaging issues so we probably need to create another release candidate. We can include this patch as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io edited a comment on pull request #9216: ARROW-11271: [Rust] [Parquet] Fix parquet list schema null conversion
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9216:
URL: https://github.com/apache/arrow/pull/9216#issuecomment-761634489
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9216?src=pr&el=h1) Report
> Merging [#9216](https://codecov.io/gh/apache/arrow/pull/9216?src=pr&el=desc) (6966a9a) into [master](https://codecov.io/gh/apache/arrow/commit/1393188e1aa1b3d59993ce7d4ade7f7ac8570959?el=desc) (1393188) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/arrow/pull/9216?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9216 +/- ##
=======================================
Coverage 81.61% 81.61%
=======================================
Files 215 215
Lines 51867 51891 +24
=======================================
+ Hits 42329 42351 +22
- Misses 9538 9540 +2
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9216?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/parquet/src/arrow/schema.rs](https://codecov.io/gh/apache/arrow/pull/9216/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9hcnJvdy9zY2hlbWEucnM=) | `91.66% <100.00%> (+0.16%)` | :arrow_up: |
| [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/9216/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `94.86% <0.00%> (-0.20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9216?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9216?src=pr&el=footer). Last update [eaa7b7a...6966a9a](https://codecov.io/gh/apache/arrow/pull/9216?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9216: ARROW-11271: [Rust] [Parquet] Fix parquet list schema null conversion
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9216:
URL: https://github.com/apache/arrow/pull/9216#issuecomment-761625364
https://issues.apache.org/jira/browse/ARROW-11271
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9216: ARROW-11271: [Rust] [Parquet] Fix parquet list schema null conversion
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9216:
URL: https://github.com/apache/arrow/pull/9216#issuecomment-761634489
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9216?src=pr&el=h1) Report
> Merging [#9216](https://codecov.io/gh/apache/arrow/pull/9216?src=pr&el=desc) (0a55bae) into [master](https://codecov.io/gh/apache/arrow/commit/1393188e1aa1b3d59993ce7d4ade7f7ac8570959?el=desc) (1393188) will **increase** coverage by `0.00%`.
> The diff coverage is `82.85%`.
[](https://codecov.io/gh/apache/arrow/pull/9216?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9216 +/- ##
=======================================
Coverage 81.61% 81.61%
=======================================
Files 215 215
Lines 51867 51893 +26
=======================================
+ Hits 42329 42352 +23
- Misses 9538 9541 +3
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9216?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/parquet/src/arrow/schema.rs](https://codecov.io/gh/apache/arrow/pull/9216/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9hcnJvdy9zY2hlbWEucnM=) | `91.38% <82.85%> (-0.13%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9216?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9216?src=pr&el=footer). Last update [eaa7b7a...6966a9a](https://codecov.io/gh/apache/arrow/pull/9216?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb closed pull request #9216: ARROW-11271: [Rust] [Parquet] Fix parquet list schema null conversion
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #9216:
URL: https://github.com/apache/arrow/pull/9216
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org