You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Chip Salzenberg (JIRA)" <ji...@apache.org> on 2010/11/13 04:18:13 UTC
[jira] Created: (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, and cleanup
Nodetool commands to query and stop compaction, repair, and cleanup
-------------------------------------------------------------------
Key: CASSANDRA-1740
URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
Project: Cassandra
Issue Type: Improvement
Components: Core
Affects Versions: 0.7 beta 3
Reporter: Chip Salzenberg
The only way to stop compaction, repair, or cleanup in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Updated] (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, cleanup and scrub
Posted by "Vijay (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vijay updated CASSANDRA-1740:
-----------------------------
Attachment: 0001-Patch-to-Stop-compactions-v3.patch
Hi Jonathan,
Moved instanceof to DTPE.logExceptionsAfterExecute
Thanks!
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Vijay
> Priority: Minor
> Labels: compaction
> Fix For: 1.0.4
>
> Attachments: 0001-Patch-to-Stop-compactions-v2.patch, 0001-Patch-to-Stop-compactions-v3.patch, 0001-Patch-to-Stop-compactions.patch, CASSANDRA-1740.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, cleanup and scrub
Posted by "Sylvain Lebresne (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147725#comment-13147725 ]
Sylvain Lebresne commented on CASSANDRA-1740:
---------------------------------------------
Let me reformulate: I *strongly* think that we shouldn't use an uncaught exception (or rather only caught by our default uncaught exception handler) for this. If we have a nodetool command to stop something, then stopping it is not an error, and thus we shouldn't have a line in the log that start with ERROR. Not only because it scares people, but also because you don't want to have false alert for any system that is grepping the log for ERROR. And also because that would be super ugly.
We do want a log message at INFO though. And it wouldn't hurt to make it as informative as we can. Something like "Stopping compaction of [sstable1, sstabl2, ...] as requested by user". Now I care less whether we use an exception internally to achieve this or not, and I could see benefits in throwing an exception for the JMX commands that are stopped, but I'm -1 on having an ERROR log message for a user triggered action.
As for stopping validation compaction, this will actually leave repair compaction hanging. It's probably ok to add it still since it's better than nothing, but this ticket should probably spawn a specific 'stop repair' ticket.
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Vijay
> Priority: Minor
> Labels: compaction
> Fix For: 1.0.3
>
> Attachments: 0001-Patch-to-Stop-compactions.patch, CASSANDRA-1740.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, cleanup and scrub
Posted by "Sylvain Lebresne (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147150#comment-13147150 ]
Sylvain Lebresne commented on CASSANDRA-1740:
---------------------------------------------
* In CompactionInfo.Holder, stop should likely be volatile
* I'm not fond of using exceptions (StoppedException) for something that is not exceptional or an error in the first place. But in particular, throwing the exception will result in a 'Fatal error' in the log, which tends to scare people, so that's another reason to avoid it.
* Stopping an AutoSavingCache task will leave a tmp file around.
* Doesn't make much sense to me to have StoppedException extend IOException since it's not. If the only goal is to avoid having to add a new checked exception, then making it a RuntimeException is imo better. But as said above, I think we shouldn't use exception for that anyway.
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Vijay
> Priority: Minor
> Labels: compaction
> Fix For: 1.0.3
>
> Attachments: 0001-Patch-to-Stop-compactions.patch, CASSANDRA-1740.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, cleanup and scrub
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140889#comment-13140889 ]
Jonathan Ellis commented on CASSANDRA-1740:
-------------------------------------------
No. I don't want to deal with trying to "freeze" compaction state for later. It's also dangerous because of the reference counting we do, to pause that indefinitely.
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Vijay
> Priority: Minor
> Fix For: 1.0.2
>
> Attachments: CASSANDRA-1740.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, cleanup and scrub
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brandon Williams updated CASSANDRA-1740:
----------------------------------------
Description: The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are. (was: The only way to stop compaction, repair, or cleanup in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.)
Summary: Nodetool commands to query and stop compaction, repair, cleanup and scrub (was: Nodetool commands to query and stop compaction, repair, and cleanup)
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.4
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, cleanup and scrub
Posted by "Vijay (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152709#comment-13152709 ]
Vijay commented on CASSANDRA-1740:
----------------------------------
Looks like calling TPE.afterExecute wont work because Throwable t is always null... http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6450211 (in java6)
I can add back the isStopped() if we are ok with the rest, plz let me know. Thanks!
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Vijay
> Priority: Minor
> Labels: compaction
> Fix For: 1.0.4
>
> Attachments: 0001-Patch-to-Stop-compactions-v2.patch, 0001-Patch-to-Stop-compactions.patch, CASSANDRA-1740.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, and cleanup
Posted by "Jon Hermes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jon Hermes reassigned CASSANDRA-1740:
-------------------------------------
Assignee: (was: Jon Hermes)
> Nodetool commands to query and stop compaction, repair, and cleanup
> -------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Priority: Minor
> Fix For: 0.7.4
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, or cleanup in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, cleanup and scrub
Posted by "Sylvain Lebresne (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne updated CASSANDRA-1740:
----------------------------------------
Attachment: 0001-Patch-to-Stop-compactions-v6.patch
Ok, I believe you were either testing on trunk or you were testing stopping cache writes. On trunk, compaction tasks are wrapped but not on 1.0 (on 1.0, only the cache writing tasks uses WrappedRunnable).
There is different way to fix but I believe the best one is to change WrappedRunnable so that it doesn't wrap RTEs. Attaching v6 that takes this approach.
(Note that I have nothing against using WrappedRunnable in 1.0 too as for trunk for compactions if we feel so inclined but I still think WrappedRunnable should not wrap RTE)
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Vijay
> Priority: Minor
> Labels: compaction
> Fix For: 1.0.5
>
> Attachments: 0001-Patch-to-Stop-compactions-v2.patch, 0001-Patch-to-Stop-compactions-v3.patch, 0001-Patch-to-Stop-compactions-v4.patch, 0001-Patch-to-Stop-compactions-v5.patch, 0001-Patch-to-Stop-compactions-v6.patch, 0001-Patch-to-Stop-compactions.patch, CASSANDRA-1740.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, cleanup and scrub
Posted by "Vijay (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vijay updated CASSANDRA-1740:
-----------------------------
Attachment: 0001-Patch-to-Stop-compactions-v2.patch
Hi Sylvain,
- we shouldn't have a line in the log that start with ERROR
I have made it to log info (with a localized message instead of error stack trace).
In this way when a person running a command will also get exception printed out. Let me know if you still want to remove throw exception. Thanks!
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Vijay
> Priority: Minor
> Labels: compaction
> Fix For: 1.0.3
>
> Attachments: 0001-Patch-to-Stop-compactions-v2.patch, 0001-Patch-to-Stop-compactions.patch, CASSANDRA-1740.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, cleanup and scrub
Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017603#comment-13017603 ]
Pavel Yaskevich commented on CASSANDRA-1740:
--------------------------------------------
I don't mind, sure.
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.5
>
> Attachments: CASSANDRA-1740.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, cleanup and scrub
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017605#comment-13017605 ]
Jonathan Ellis commented on CASSANDRA-1740:
-------------------------------------------
Repair is tough since it interacts with other nodes. Let's leave that alone for now.
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.5
>
> Attachments: CASSANDRA-1740.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, cleanup and scrub
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018315#comment-13018315 ]
Sylvain Lebresne commented on CASSANDRA-1740:
---------------------------------------------
As for handling the multi-threaded compactions, the hashcode would more or less work but since it's not totally safe I would prefer assigning a name to each compaction which could be:
* a uuid assigned to each compaction when created
* a simple (atomically) increasing number
* a simple (atomically) increasing number for each type of compaction, the name being something like major-42 or minor-3012. Nice thing is it tells you how many minor, major, validata, ... compaction you have run already.
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.5
>
> Attachments: CASSANDRA-1740.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, cleanup and scrub
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis reassigned CASSANDRA-1740:
-----------------------------------------
Assignee: Pavel Yaskevich (was: Stu Hood)
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.8.2
>
> Attachments: CASSANDRA-1740.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, and cleanup
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis reassigned CASSANDRA-1740:
-----------------------------------------
Assignee: Pavel Yaskevich
> Nodetool commands to query and stop compaction, repair, and cleanup
> -------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.4
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, or cleanup in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, cleanup and scrub
Posted by "Vijay (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140878#comment-13140878 ]
Vijay commented on CASSANDRA-1740:
----------------------------------
Will it make more sense to have a commands like pause compaction via "nt pause compaction" and resume via "nt resume compaction"? instead of "nt stop compaction"
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Vijay
> Priority: Minor
> Fix For: 1.0.2
>
> Attachments: CASSANDRA-1740.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, cleanup and scrub
Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018303#comment-13018303 ]
Pavel Yaskevich commented on CASSANDRA-1740:
--------------------------------------------
Stu Hood: do you want to be in charge of this one since your changes in compaction mechanism?
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.5
>
> Attachments: CASSANDRA-1740.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, cleanup and scrub
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018310#comment-13018310 ]
Sylvain Lebresne commented on CASSANDRA-1740:
---------------------------------------------
I committed CASSANDRA-2191 so as stu said, this will need some rebasing to handle it.
For repair, let's just create another ticket. If stu wants/have time to do it, fine, otherwise I may do it.
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.5
>
> Attachments: CASSANDRA-1740.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, cleanup and scrub
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152844#comment-13152844 ]
Jonathan Ellis commented on CASSANDRA-1740:
-------------------------------------------
Why not just make StoppedException extend RuntimeException?
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Vijay
> Priority: Minor
> Labels: compaction
> Fix For: 1.0.4
>
> Attachments: 0001-Patch-to-Stop-compactions-v2.patch, 0001-Patch-to-Stop-compactions.patch, CASSANDRA-1740.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, cleanup and scrub
Posted by "Vijay (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vijay updated CASSANDRA-1740:
-----------------------------
Attachment: 0001-Patch-to-Stop-compactions-v5.patch
the only difference from v4 in v5 is
if (actualException.getCause() != null && actualException.getCause() instanceof UserInterruptedException)
Otherwise there will be a error in the log. Thanks!
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Vijay
> Priority: Minor
> Labels: compaction
> Fix For: 1.0.4
>
> Attachments: 0001-Patch-to-Stop-compactions-v2.patch, 0001-Patch-to-Stop-compactions-v3.patch, 0001-Patch-to-Stop-compactions-v4.patch, 0001-Patch-to-Stop-compactions-v5.patch, 0001-Patch-to-Stop-compactions.patch, CASSANDRA-1740.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, cleanup and scrub
Posted by "Sylvain Lebresne (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156624#comment-13156624 ]
Sylvain Lebresne commented on CASSANDRA-1740:
---------------------------------------------
I don't understand. Did you actually try v4 and got an exception in the log? actualException is already the cause of the ExecutionException, so it is directly the UserInterruptedException, unless that latter gets further encapsulated by another exception but I see nowhere in the code where that could happen. And as a matter of fact, if you do try stopping a compaction, both v3 and v5 do log an error, while v4 does not. If your testing differs, there is something going on.
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Vijay
> Priority: Minor
> Labels: compaction
> Fix For: 1.0.4
>
> Attachments: 0001-Patch-to-Stop-compactions-v2.patch, 0001-Patch-to-Stop-compactions-v3.patch, 0001-Patch-to-Stop-compactions-v4.patch, 0001-Patch-to-Stop-compactions-v5.patch, 0001-Patch-to-Stop-compactions.patch, CASSANDRA-1740.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, and cleanup
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-1740:
--------------------------------------
Remaining Estimate: 24h
Original Estimate: 24h
> Nodetool commands to query and stop compaction, repair, and cleanup
> -------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Jon Hermes
> Priority: Minor
> Fix For: 0.7.1
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, or cleanup in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Updated] (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, cleanup and scrub
Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Yaskevich updated CASSANDRA-1740:
---------------------------------------
Attachment: CASSANDRA-1740.patch
it supports stopping cleanup, scrub, and both minor/major compactions. I'm not sure if we should do the same thing for repair, what do you think, Jonathan?
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.5
>
> Attachments: CASSANDRA-1740.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, and cleanup
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-1740:
--------------------------------------
Component/s: (was: Core)
Tools
Priority: Minor (was: Major)
Affects Version/s: (was: 0.7 beta 3)
Fix Version/s: 0.7.1
Assignee: Jon Hermes
> Nodetool commands to query and stop compaction, repair, and cleanup
> -------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Jon Hermes
> Priority: Minor
> Fix For: 0.7.1
>
>
> The only way to stop compaction, repair, or cleanup in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Updated] (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, cleanup and scrub
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-1740:
--------------------------------------
Fix Version/s: (was: 0.7.6)
0.8.1
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Stu Hood
> Priority: Minor
> Fix For: 0.8.1
>
> Attachments: CASSANDRA-1740.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, cleanup and scrub
Posted by "Vijay (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147232#comment-13147232 ]
Vijay commented on CASSANDRA-1740:
----------------------------------
I can do all of the above, but i still think it is an Exception because someone/something interrupted (agree about runtime exception and will add more message so users wont panic). It will be easier to maintain later because people dont need to understand a return vs exception, they just need to worry about is an exception will be thrown somewhere.
I can remove the exception and just do return if stopped if we prefer otherwise, let me know.
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Vijay
> Priority: Minor
> Labels: compaction
> Fix For: 1.0.3
>
> Attachments: 0001-Patch-to-Stop-compactions.patch, CASSANDRA-1740.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, cleanup and scrub
Posted by "Sylvain Lebresne (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne updated CASSANDRA-1740:
----------------------------------------
Attachment: 0001-Patch-to-Stop-compactions-v4.patch
Looks good except that I believe logExceptionAfterExecute uses one too many getCause() so that the UserInterruptedException is not actually catched. Attaching v4 that solves this as well as the following minor changes:
* make UserInteruptedException takes a CompactionInfo directly and generate the message internally (instead of duplicating the same message at each call site).
* remove an added and non used logger in CompactionInfo
* update the nodetool help message to respect the convention for mandatory arguments.
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Vijay
> Priority: Minor
> Labels: compaction
> Fix For: 1.0.4
>
> Attachments: 0001-Patch-to-Stop-compactions-v2.patch, 0001-Patch-to-Stop-compactions-v3.patch, 0001-Patch-to-Stop-compactions-v4.patch, 0001-Patch-to-Stop-compactions.patch, CASSANDRA-1740.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (CASSANDRA-1740) Nodetool commands to
query and stop compaction, repair, cleanup and scrub
Posted by "Vijay (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156810#comment-13156810 ]
Vijay edited comment on CASSANDRA-1740 at 11/24/11 5:27 PM:
------------------------------------------------------------
Yeah I did try it and saw the exception, I was not sure who is wrapping it again with RTE.
To be more clear:
The RTE additional wrap is because WrappableRunnable which catches all Exceptions just to wrap it to a RTE (plz check http://grepcode.com/file/repository.grepcode.com/java/root/jdk/openjdk/6-b14/java/lang/RuntimeException.java). Hope this helps :)
was (Author: vijay2win@yahoo.com):
Yeah I did try it and saw the exception, I was not sure who is wrapping it again with rte.
Sent from my iPhone
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Vijay
> Priority: Minor
> Labels: compaction
> Fix For: 1.0.4
>
> Attachments: 0001-Patch-to-Stop-compactions-v2.patch, 0001-Patch-to-Stop-compactions-v3.patch, 0001-Patch-to-Stop-compactions-v4.patch, 0001-Patch-to-Stop-compactions-v5.patch, 0001-Patch-to-Stop-compactions.patch, CASSANDRA-1740.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, cleanup and scrub
Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Yaskevich updated CASSANDRA-1740:
---------------------------------------
Assignee: Stu Hood (was: Pavel Yaskevich)
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Stu Hood
> Priority: Minor
> Fix For: 0.7.6
>
> Attachments: CASSANDRA-1740.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, cleanup and scrub
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-1740:
--------------------------------------
Fix Version/s: (was: 0.8.5)
1.1
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 1.1
>
> Attachments: CASSANDRA-1740.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, cleanup and scrub
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017599#comment-13017599 ]
Stu Hood commented on CASSANDRA-1740:
-------------------------------------
If you don't mind, I'd really like to get CASSANDRA-2191 in first, as it will change the semantics of this ticket quite a bit. In particular, it looks like you'll need a compaction id to decide what to stop: I'm currently exposing the CI hashcode, which might do the trick.
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.5
>
> Attachments: CASSANDRA-1740.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, cleanup and scrub
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151251#comment-13151251 ]
Jonathan Ellis commented on CASSANDRA-1740:
-------------------------------------------
I'm not a fan of the instanceof UIE in the default exception handler. Feels spaghetti-ish to me.
What about checking for UIE in the compactionexecutor afterExecute? That would address the DRY problem without violating encapsulation so badly.
Nit: would prefer mutable fields to be private and exposed via getter if necessary, e.g. would use Holder.isStopped() here.
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Vijay
> Priority: Minor
> Labels: compaction
> Fix For: 1.0.4
>
> Attachments: 0001-Patch-to-Stop-compactions-v2.patch, 0001-Patch-to-Stop-compactions.patch, CASSANDRA-1740.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, cleanup and scrub
Posted by "Jonathan Ellis (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-1740:
--------------------------------------
Fix Version/s: (was: 1.0.5)
1.1
Reverted from 1.0.6 to avoid possible introduction of instability. (E.g., CASSANDRA-3566.) Left the WrappedRunnable improvement.
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Vijay
> Priority: Minor
> Labels: compaction
> Fix For: 1.1
>
> Attachments: 0001-Patch-to-Stop-compactions-v2.patch, 0001-Patch-to-Stop-compactions-v3.patch, 0001-Patch-to-Stop-compactions-v4.patch, 0001-Patch-to-Stop-compactions-v5.patch, 0001-Patch-to-Stop-compactions-v6.patch, 0001-Patch-to-Stop-compactions.patch, CASSANDRA-1740.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, and cleanup
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brandon Williams updated CASSANDRA-1740:
----------------------------------------
Fix Version/s: (was: 0.7.2)
0.7.3
> Nodetool commands to query and stop compaction, repair, and cleanup
> -------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Jon Hermes
> Priority: Minor
> Fix For: 0.7.3
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, or cleanup in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, cleanup and scrub
Posted by "Jonathan Ellis (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis reassigned CASSANDRA-1740:
-----------------------------------------
Assignee: Vijay (was: Pavel Yaskevich)
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Vijay
> Priority: Minor
> Fix For: 1.0.2
>
> Attachments: CASSANDRA-1740.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, cleanup and scrub
Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018316#comment-13018316 ]
Pavel Yaskevich commented on CASSANDRA-1740:
--------------------------------------------
I like the last option!
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.5
>
> Attachments: CASSANDRA-1740.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, cleanup and scrub
Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017606#comment-13017606 ]
Pavel Yaskevich commented on CASSANDRA-1740:
--------------------------------------------
Great, thank you!
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.5
>
> Attachments: CASSANDRA-1740.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, cleanup and scrub
Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13021521#comment-13021521 ]
Pavel Yaskevich commented on CASSANDRA-1740:
--------------------------------------------
sgtm
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.6
>
> Attachments: CASSANDRA-1740.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, cleanup and scrub
Posted by "Stu Hood (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130976#comment-13130976 ]
Stu Hood commented on CASSANDRA-1740:
-------------------------------------
Hey Pavel, sorry: I should have commented ages ago: I won't be working on this.
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 1.0.1
>
> Attachments: CASSANDRA-1740.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, cleanup and scrub
Posted by "Vijay (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157351#comment-13157351 ]
Vijay commented on CASSANDRA-1740:
----------------------------------
+1, Thanks!
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Vijay
> Priority: Minor
> Labels: compaction
> Fix For: 1.0.5
>
> Attachments: 0001-Patch-to-Stop-compactions-v2.patch, 0001-Patch-to-Stop-compactions-v3.patch, 0001-Patch-to-Stop-compactions-v4.patch, 0001-Patch-to-Stop-compactions-v5.patch, 0001-Patch-to-Stop-compactions-v6.patch, 0001-Patch-to-Stop-compactions.patch, CASSANDRA-1740.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, cleanup and scrub
Posted by "Vijay (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156810#comment-13156810 ]
Vijay commented on CASSANDRA-1740:
----------------------------------
Yeah I did try it and saw the exception, I was not sure who is wrapping it again with rte.
Sent from my iPhone
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Vijay
> Priority: Minor
> Labels: compaction
> Fix For: 1.0.4
>
> Attachments: 0001-Patch-to-Stop-compactions-v2.patch, 0001-Patch-to-Stop-compactions-v3.patch, 0001-Patch-to-Stop-compactions-v4.patch, 0001-Patch-to-Stop-compactions-v5.patch, 0001-Patch-to-Stop-compactions.patch, CASSANDRA-1740.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, cleanup and scrub
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-1740:
--------------------------------------
Fix Version/s: (was: 0.7.5)
0.7.6
Stu, are you planning to multithreadify this, then?
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.6
>
> Attachments: CASSANDRA-1740.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, cleanup and scrub
Posted by "Vijay (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vijay updated CASSANDRA-1740:
-----------------------------
Attachment: 0001-Patch-to-Stop-compactions.patch
Attached patch can stop the following, COMPACTION, VALIDATION, KEY_CACHE_SAVE, ROW_CACHE_SAVE,CLEANUP, SCRUB, INDEX_BUILD
nt stop <compaction type>
but for the minor compaction when we run stop it starts immediately hence i am not sure if this will help to stop the minor compactions but it is definitely better than restarting.
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Vijay
> Priority: Minor
> Fix For: 1.0.2
>
> Attachments: 0001-Patch-to-Stop-compactions.patch, CASSANDRA-1740.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-1740) Nodetool commands to query and
stop compaction, repair, cleanup and scrub
Posted by "Pavel Yaskevich (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130930#comment-13130930 ]
Pavel Yaskevich commented on CASSANDRA-1740:
--------------------------------------------
Stu, are you still planning to work on this?
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-1740
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Chip Salzenberg
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 1.0.1
>
> Attachments: CASSANDRA-1740.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and restart the entire Cassandra server. Please provide nodetool commands to query whether such things are running, and stop them if they are.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira