You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Simone Tripodi (JIRA)" <ji...@apache.org> on 2016/08/05 09:47:20 UTC

[jira] [Updated] (SLING-5913) Clean-up the Distribution Core source code

     [ https://issues.apache.org/jira/browse/SLING-5913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simone Tripodi updated SLING-5913:
----------------------------------
    Attachment: SLING-5913.3.patch

Hi again [~teofili],
I think {{if/then/else}} statements can be dropped in favour of direct accesses especially when involving {{Enum}}s, the latest submitted patch tries to clean-up as mush as I noticed.
Moreover, {{equals()}} in {{Emu}}s is just a {{==}} override, so I modified a little also the source to make it more readable.
HTH!

> Clean-up the Distribution Core source code
> ------------------------------------------
>
>                 Key: SLING-5913
>                 URL: https://issues.apache.org/jira/browse/SLING-5913
>             Project: Sling
>          Issue Type: Improvement
>          Components: Distribution
>    Affects Versions: Content Distribution Core 0.1.18
>            Reporter: Simone Tripodi
>            Assignee: Tommaso Teofili
>            Priority: Minor
>             Fix For: Content Distribution 0.2.0
>
>         Attachments: SLING-5913.1.patch, SLING-5913.2.patch, SLING-5913.3.patch, SLING-5913.patch
>
>
> Current codebase is full of warnings due to unbound generics type, not used variables, ... that makes code reading less pleasant than expected



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)