You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/18 04:02:22 UTC
[GitHub] [spark] c21 opened a new pull request #31873: [SPARK-34781][SQL] Eliminate LEFT SEMI/ANTI joins to its left child side in AQE
c21 opened a new pull request #31873:
URL: https://github.com/apache/spark/pull/31873
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
In `EliminateJoinToEmptyRelation.scala`, we can extend it to cover more cases for LEFT SEMI and LEFT ANI joins:
* Join is left semi join, join right side is non-empty and condition is empty. Eliminate join to its left side.
* Join is left anti join, join right side is empty. Eliminate join to its left side.
Given we eliminate join to its left side here, renaming the current optimization rule to `EliminateUnnecessaryJoin` instead.
In addition, also change to use `checkRowCount()` to check run time row count, instead of using `EmptyHashedRelation`. So this can cover `BroadcastNestedLoopJoin` as well. (`BroadcastNestedLoopJoin`'s broadcast side is `Array[InternalRow]`, not `HashedRelation`).
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Cover more join cases, and improve query performance for affected queries.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Added unit tests in `AdaptiveQueryExecSuite.scala`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #31873: [SPARK-34781][SQL] Eliminate LEFT SEMI/ANTI joins to its left child side in AQE
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31873:
URL: https://github.com/apache/spark/pull/31873#discussion_r597328799
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/EliminateUnnecessaryJoin.scala
##########
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.adaptive
+
+import org.apache.spark.sql.catalyst.planning.ExtractSingleColumnNullAwareAntiJoin
+import org.apache.spark.sql.catalyst.plans.{Inner, LeftAnti, LeftSemi}
+import org.apache.spark.sql.catalyst.plans.logical.{Join, LocalRelation, LogicalPlan}
+import org.apache.spark.sql.catalyst.rules.Rule
+import org.apache.spark.sql.execution.joins.HashedRelationWithAllNullKeys
+
+/**
+ * This optimization rule detects and eliminates unnecessary Join:
+ * 1. Join is single column NULL-aware anti join (NAAJ), and broadcasted [[HashedRelation]]
+ * is [[HashedRelationWithAllNullKeys]]. Eliminate join to an empty [[LocalRelation]].
+ *
+ * 2. Join is inner join, and either side of join is empty. Eliminate join to an empty
+ * [[LocalRelation]].
+ *
+ * 3. Join is left semi join
+ * 3.1. Join right side is empty. Eliminate join to an empty [[LocalRelation]].
+ * 3.2. Join right side is non-empty and condition is empty. Eliminate join to its left side.
+ *
+ * 4. Join is left anti join
+ * 4.1. Join right side is empty. Eliminate join to its left side.
+ * 4.2. Join right side is non-empty and condition is empty. Eliminate join to an empty
+ * [[LocalRelation]].
+ *
+ * This applies to all joins (sort merge join, shuffled hash join, broadcast hash join, and
+ * broadcast nested loop join), because sort merge join and shuffled hash join will be changed
+ * to broadcast hash join with AQE at the first place.
+ */
+object EliminateUnnecessaryJoin extends Rule[LogicalPlan] {
+
+ private def isRelationWithAllNullKeys(plan: LogicalPlan) = plan match {
+ case LogicalQueryStage(_, stage: BroadcastQueryStageExec)
+ if stage.resultOption.get().isDefined =>
+ stage.broadcast.relationFuture.get().value == HashedRelationWithAllNullKeys
+ case _ => false
+ }
+
+ private def checkRowCount(plan: LogicalPlan, hasRow: Boolean): Boolean = plan match {
Review comment:
ah, my bad. I meant `checkRowCount` -> `hasNoRow `:
```
case j @ Join(_, _, Inner, _, _) if hasNoRow(j.left) ||
...
case j @ Join(_, _, LeftSemi, condition, _) =>
if (hasNoRow(j.right)) {
LocalRelation(j.output, data = Seq.empty, isStreaming = j.isStreaming)
} else if (condition.isEmpty && !hasNoRow(j.right)) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31873: [SPARK-34781][SQL] Eliminate LEFT SEMI/ANTI joins to its left child side in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31873:
URL: https://github.com/apache/spark/pull/31873#issuecomment-801470453
**[Test build #136179 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136179/testReport)** for PR 31873 at commit [`95f3fa0`](https://github.com/apache/spark/commit/95f3fa08fb3cb7ac2fe03c12e36c63bf468db241).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31873: [SPARK-34781][SQL] Eliminate LEFT SEMI/ANTI joins to its left child side in AQE
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31873:
URL: https://github.com/apache/spark/pull/31873#issuecomment-802418641
Thanks! Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on a change in pull request #31873: [SPARK-34781][SQL] Eliminate LEFT SEMI/ANTI joins to its left child side in AQE
Posted by GitBox <gi...@apache.org>.
c21 commented on a change in pull request #31873:
URL: https://github.com/apache/spark/pull/31873#discussion_r596411583
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/EliminateUnnecessaryJoin.scala
##########
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.adaptive
+
+import org.apache.spark.sql.catalyst.planning.ExtractSingleColumnNullAwareAntiJoin
+import org.apache.spark.sql.catalyst.plans.{Inner, LeftAnti, LeftSemi}
+import org.apache.spark.sql.catalyst.plans.logical.{Join, LocalRelation, LogicalPlan}
+import org.apache.spark.sql.catalyst.rules.Rule
+import org.apache.spark.sql.execution.joins.HashedRelationWithAllNullKeys
+
+/**
+ * This optimization rule detects and eliminates unnecessary Join:
+ * 1. Join is single column NULL-aware anti join (NAAJ), and broadcasted [[HashedRelation]]
+ * is [[HashedRelationWithAllNullKeys]]. Eliminate join to an empty [[LocalRelation]].
+ *
+ * 2. Join is inner join, and either side of join is empty. Eliminate join to an empty
+ * [[LocalRelation]].
+ *
+ * 3. Join is left semi join
+ * 3.1. Join right side is empty. Eliminate join to an empty [[LocalRelation]].
+ * 3.2. Join right side is non-empty and condition is empty. Eliminate join to its left side.
+ *
+ * 4. Join is left anti join
+ * 4.1. Join right side is empty. Eliminate join to its left side.
+ * 4.2. Join right side is non-empty and condition is empty. Eliminate join to an empty
+ * [[LocalRelation]].
+ *
+ * This applies to all joins (sort merge join, shuffled hash join, broadcast hash join, and
+ * broadcast nested loop join), because sort merge join and shuffled hash join will be changed
+ * to broadcast hash join with AQE at the first place.
+ */
+object EliminateUnnecessaryJoin extends Rule[LogicalPlan] {
+
+ private def isRelationWithAllNullKeys(plan: LogicalPlan) = plan match {
+ case LogicalQueryStage(_, stage: BroadcastQueryStageExec)
+ if stage.resultOption.get().isDefined =>
+ stage.broadcast.relationFuture.get().value == HashedRelationWithAllNullKeys
+ case _ => false
+ }
+
+ private def checkRowCount(plan: LogicalPlan, hasRow: Boolean): Boolean = plan match {
Review comment:
This is added compared to previous `EliminateJoinToEmptyRelation.scala`.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/EliminateUnnecessaryJoin.scala
##########
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.adaptive
+
+import org.apache.spark.sql.catalyst.planning.ExtractSingleColumnNullAwareAntiJoin
+import org.apache.spark.sql.catalyst.plans.{Inner, LeftAnti, LeftSemi}
+import org.apache.spark.sql.catalyst.plans.logical.{Join, LocalRelation, LogicalPlan}
+import org.apache.spark.sql.catalyst.rules.Rule
+import org.apache.spark.sql.execution.joins.HashedRelationWithAllNullKeys
+
+/**
+ * This optimization rule detects and eliminates unnecessary Join:
+ * 1. Join is single column NULL-aware anti join (NAAJ), and broadcasted [[HashedRelation]]
+ * is [[HashedRelationWithAllNullKeys]]. Eliminate join to an empty [[LocalRelation]].
+ *
+ * 2. Join is inner join, and either side of join is empty. Eliminate join to an empty
+ * [[LocalRelation]].
+ *
+ * 3. Join is left semi join
+ * 3.1. Join right side is empty. Eliminate join to an empty [[LocalRelation]].
+ * 3.2. Join right side is non-empty and condition is empty. Eliminate join to its left side.
+ *
+ * 4. Join is left anti join
+ * 4.1. Join right side is empty. Eliminate join to its left side.
+ * 4.2. Join right side is non-empty and condition is empty. Eliminate join to an empty
+ * [[LocalRelation]].
+ *
+ * This applies to all joins (sort merge join, shuffled hash join, broadcast hash join, and
+ * broadcast nested loop join), because sort merge join and shuffled hash join will be changed
+ * to broadcast hash join with AQE at the first place.
+ */
+object EliminateUnnecessaryJoin extends Rule[LogicalPlan] {
+
+ private def isRelationWithAllNullKeys(plan: LogicalPlan) = plan match {
Review comment:
This is slightly changed compared to previous `EliminateJoinToEmptyRelation.scala`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31873: [SPARK-34781][SQL] Eliminate LEFT SEMI/ANTI joins to its left child side in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31873:
URL: https://github.com/apache/spark/pull/31873#issuecomment-801621812
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on a change in pull request #31873: [SPARK-34781][SQL] Eliminate LEFT SEMI/ANTI joins to its left child side in AQE
Posted by GitBox <gi...@apache.org>.
c21 commented on a change in pull request #31873:
URL: https://github.com/apache/spark/pull/31873#discussion_r597327356
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/EliminateUnnecessaryJoin.scala
##########
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.adaptive
+
+import org.apache.spark.sql.catalyst.planning.ExtractSingleColumnNullAwareAntiJoin
+import org.apache.spark.sql.catalyst.plans.{Inner, LeftAnti, LeftSemi}
+import org.apache.spark.sql.catalyst.plans.logical.{Join, LocalRelation, LogicalPlan}
+import org.apache.spark.sql.catalyst.rules.Rule
+import org.apache.spark.sql.execution.joins.HashedRelationWithAllNullKeys
+
+/**
+ * This optimization rule detects and eliminates unnecessary Join:
+ * 1. Join is single column NULL-aware anti join (NAAJ), and broadcasted [[HashedRelation]]
+ * is [[HashedRelationWithAllNullKeys]]. Eliminate join to an empty [[LocalRelation]].
+ *
+ * 2. Join is inner join, and either side of join is empty. Eliminate join to an empty
+ * [[LocalRelation]].
+ *
+ * 3. Join is left semi join
+ * 3.1. Join right side is empty. Eliminate join to an empty [[LocalRelation]].
+ * 3.2. Join right side is non-empty and condition is empty. Eliminate join to its left side.
+ *
+ * 4. Join is left anti join
+ * 4.1. Join right side is empty. Eliminate join to its left side.
+ * 4.2. Join right side is non-empty and condition is empty. Eliminate join to an empty
+ * [[LocalRelation]].
+ *
+ * This applies to all joins (sort merge join, shuffled hash join, broadcast hash join, and
+ * broadcast nested loop join), because sort merge join and shuffled hash join will be changed
+ * to broadcast hash join with AQE at the first place.
+ */
+object EliminateUnnecessaryJoin extends Rule[LogicalPlan] {
+
+ private def isRelationWithAllNullKeys(plan: LogicalPlan) = plan match {
+ case LogicalQueryStage(_, stage: BroadcastQueryStageExec)
+ if stage.resultOption.get().isDefined =>
+ stage.broadcast.relationFuture.get().value == HashedRelationWithAllNullKeys
+ case _ => false
+ }
+
+ private def checkRowCount(plan: LogicalPlan, hasRow: Boolean): Boolean = plan match {
Review comment:
@maropu - sorry I don't quite get here, `checkRowCount(j.right, hasRow = false` still exists in your example. Am I missing anything? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31873: [SPARK-34781][SQL] Eliminate LEFT SEMI/ANTI joins to its left child side in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31873:
URL: https://github.com/apache/spark/pull/31873#issuecomment-801470453
**[Test build #136179 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136179/testReport)** for PR 31873 at commit [`95f3fa0`](https://github.com/apache/spark/commit/95f3fa08fb3cb7ac2fe03c12e36c63bf468db241).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #31873: [SPARK-34781][SQL] Eliminate LEFT SEMI/ANTI joins to its left child side in AQE
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31873:
URL: https://github.com/apache/spark/pull/31873#discussion_r597325979
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/EliminateUnnecessaryJoin.scala
##########
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.adaptive
+
+import org.apache.spark.sql.catalyst.planning.ExtractSingleColumnNullAwareAntiJoin
+import org.apache.spark.sql.catalyst.plans.{Inner, LeftAnti, LeftSemi}
+import org.apache.spark.sql.catalyst.plans.logical.{Join, LocalRelation, LogicalPlan}
+import org.apache.spark.sql.catalyst.rules.Rule
+import org.apache.spark.sql.execution.joins.HashedRelationWithAllNullKeys
+
+/**
+ * This optimization rule detects and eliminates unnecessary Join:
+ * 1. Join is single column NULL-aware anti join (NAAJ), and broadcasted [[HashedRelation]]
+ * is [[HashedRelationWithAllNullKeys]]. Eliminate join to an empty [[LocalRelation]].
+ *
+ * 2. Join is inner join, and either side of join is empty. Eliminate join to an empty
+ * [[LocalRelation]].
+ *
+ * 3. Join is left semi join
+ * 3.1. Join right side is empty. Eliminate join to an empty [[LocalRelation]].
+ * 3.2. Join right side is non-empty and condition is empty. Eliminate join to its left side.
+ *
+ * 4. Join is left anti join
+ * 4.1. Join right side is empty. Eliminate join to its left side.
+ * 4.2. Join right side is non-empty and condition is empty. Eliminate join to an empty
+ * [[LocalRelation]].
+ *
+ * This applies to all joins (sort merge join, shuffled hash join, broadcast hash join, and
+ * broadcast nested loop join), because sort merge join and shuffled hash join will be changed
+ * to broadcast hash join with AQE at the first place.
+ */
+object EliminateUnnecessaryJoin extends Rule[LogicalPlan] {
+
+ private def isRelationWithAllNullKeys(plan: LogicalPlan) = plan match {
+ case LogicalQueryStage(_, stage: BroadcastQueryStageExec)
+ if stage.resultOption.get().isDefined =>
+ stage.broadcast.relationFuture.get().value == HashedRelationWithAllNullKeys
+ case _ => false
+ }
+
+ private def checkRowCount(plan: LogicalPlan, hasRow: Boolean): Boolean = plan match {
Review comment:
nit comment: we need the `hasRow` param? How about simply checking `count == 0` like this?
```
private def hasNoRow(plan: LogicalPlan): Boolean = plan match {
case LogicalQueryStage(_, stage: QueryStageExec) if stage.resultOption.get().isDefined =>
stage.getRuntimeStatistics.rowCount match {
case Some(count) => count == 0
case _ => false
}
case _ => false
}
```
Then,
```
case j @ Join(_, _, Inner, _, _) if hasNoRow(j.left) ||
...
case j @ Join(_, _, LeftSemi, condition, _) =>
if (checkRowCount(j.right, hasRow = false)) {
LocalRelation(j.output, data = Seq.empty, isStreaming = j.isStreaming)
} else if (condition.isEmpty && !hasNoRow(j.right)) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 closed pull request #31873: [SPARK-34781][SQL] Eliminate LEFT SEMI/ANTI joins to its left child side in AQE
Posted by GitBox <gi...@apache.org>.
c21 closed pull request #31873:
URL: https://github.com/apache/spark/pull/31873
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31873: [SPARK-34781][SQL] Eliminate LEFT SEMI/ANTI joins to its left child side in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31873:
URL: https://github.com/apache/spark/pull/31873#issuecomment-801471740
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136179/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31873: [SPARK-34781][SQL] Eliminate LEFT SEMI/ANTI joins to its left child side in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31873:
URL: https://github.com/apache/spark/pull/31873#issuecomment-801539792
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136183/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #31873: [SPARK-34781][SQL] Eliminate LEFT SEMI/ANTI joins to its left child side in AQE
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31873:
URL: https://github.com/apache/spark/pull/31873#discussion_r597333024
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/EliminateUnnecessaryJoin.scala
##########
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.adaptive
+
+import org.apache.spark.sql.catalyst.planning.ExtractSingleColumnNullAwareAntiJoin
+import org.apache.spark.sql.catalyst.plans.{Inner, LeftAnti, LeftSemi}
+import org.apache.spark.sql.catalyst.plans.logical.{Join, LocalRelation, LogicalPlan}
+import org.apache.spark.sql.catalyst.rules.Rule
+import org.apache.spark.sql.execution.joins.HashedRelationWithAllNullKeys
+
+/**
+ * This optimization rule detects and eliminates unnecessary Join:
+ * 1. Join is single column NULL-aware anti join (NAAJ), and broadcasted [[HashedRelation]]
+ * is [[HashedRelationWithAllNullKeys]]. Eliminate join to an empty [[LocalRelation]].
+ *
+ * 2. Join is inner join, and either side of join is empty. Eliminate join to an empty
+ * [[LocalRelation]].
+ *
+ * 3. Join is left semi join
+ * 3.1. Join right side is empty. Eliminate join to an empty [[LocalRelation]].
+ * 3.2. Join right side is non-empty and condition is empty. Eliminate join to its left side.
+ *
+ * 4. Join is left anti join
+ * 4.1. Join right side is empty. Eliminate join to its left side.
+ * 4.2. Join right side is non-empty and condition is empty. Eliminate join to an empty
+ * [[LocalRelation]].
+ *
+ * This applies to all joins (sort merge join, shuffled hash join, broadcast hash join, and
+ * broadcast nested loop join), because sort merge join and shuffled hash join will be changed
+ * to broadcast hash join with AQE at the first place.
+ */
+object EliminateUnnecessaryJoin extends Rule[LogicalPlan] {
+
+ private def isRelationWithAllNullKeys(plan: LogicalPlan) = plan match {
+ case LogicalQueryStage(_, stage: BroadcastQueryStageExec)
+ if stage.resultOption.get().isDefined =>
+ stage.broadcast.relationFuture.get().value == HashedRelationWithAllNullKeys
+ case _ => false
+ }
+
+ private def checkRowCount(plan: LogicalPlan, hasRow: Boolean): Boolean = plan match {
Review comment:
Ah, okay. I got your point. sgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31873: [SPARK-34781][SQL] Eliminate LEFT SEMI/ANTI joins to its left child side in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31873:
URL: https://github.com/apache/spark/pull/31873#issuecomment-801618425
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40774/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on a change in pull request #31873: [SPARK-34781][SQL] Eliminate LEFT SEMI/ANTI joins to its left child side in AQE
Posted by GitBox <gi...@apache.org>.
c21 commented on a change in pull request #31873:
URL: https://github.com/apache/spark/pull/31873#discussion_r596412016
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
##########
@@ -1254,21 +1254,38 @@ class AdaptiveQueryExecSuite
test("SPARK-34533: Eliminate left anti join to empty relation") {
withSQLConf(
SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "true") {
- withTable("emptyTestData") {
- spark.range(0).write.saveAsTable("emptyTestData")
- Seq(
- // broadcast non-empty right side
- ("SELECT /*+ broadcast(testData3) */ * FROM testData LEFT ANTI JOIN testData3", true),
- // broadcast empty right side
- ("SELECT /*+ broadcast(emptyTestData) */ * FROM testData LEFT ANTI JOIN emptyTestData",
- false),
- // broadcast left side
- ("SELECT /*+ broadcast(testData) */ * FROM testData LEFT ANTI JOIN testData3", false)
- ).foreach { case (query, isEliminated) =>
- val (plan, adaptivePlan) = runAdaptiveAndVerifyResult(query)
- assert(findTopLevelBaseJoin(plan).size == 1)
- assert(findTopLevelBaseJoin(adaptivePlan).isEmpty == isEliminated)
- }
+ Seq(
+ // broadcast non-empty right side
+ ("SELECT /*+ broadcast(testData3) */ * FROM testData LEFT ANTI JOIN testData3", true),
+ // broadcast empty right side
+ ("SELECT /*+ broadcast(emptyTestData) */ * FROM testData LEFT ANTI JOIN emptyTestData",
+ true),
Review comment:
This is true now as we eliminate join to its left side.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #31873: [SPARK-34781][SQL] Eliminate LEFT SEMI/ANTI joins to its left child side in AQE
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #31873:
URL: https://github.com/apache/spark/pull/31873#issuecomment-801471736
cc @cloud-fan and @maropu could you help take a look when you have time, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31873: [SPARK-34781][SQL] Eliminate LEFT SEMI/ANTI joins to its left child side in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31873:
URL: https://github.com/apache/spark/pull/31873#issuecomment-801621577
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40774/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu closed pull request #31873: [SPARK-34781][SQL] Eliminate LEFT SEMI/ANTI joins to its left child side in AQE
Posted by GitBox <gi...@apache.org>.
maropu closed pull request #31873:
URL: https://github.com/apache/spark/pull/31873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31873: [SPARK-34781][SQL] Eliminate LEFT SEMI/ANTI joins to its left child side in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31873:
URL: https://github.com/apache/spark/pull/31873#issuecomment-801471722
**[Test build #136179 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136179/testReport)** for PR 31873 at commit [`95f3fa0`](https://github.com/apache/spark/commit/95f3fa08fb3cb7ac2fe03c12e36c63bf468db241).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31873: [SPARK-34781][SQL] Eliminate LEFT SEMI/ANTI joins to its left child side in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31873:
URL: https://github.com/apache/spark/pull/31873#issuecomment-801539792
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136183/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on a change in pull request #31873: [SPARK-34781][SQL] Eliminate LEFT SEMI/ANTI joins to its left child side in AQE
Posted by GitBox <gi...@apache.org>.
c21 commented on a change in pull request #31873:
URL: https://github.com/apache/spark/pull/31873#discussion_r596413151
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
##########
@@ -1254,21 +1254,38 @@ class AdaptiveQueryExecSuite
test("SPARK-34533: Eliminate left anti join to empty relation") {
withSQLConf(
SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "true") {
- withTable("emptyTestData") {
Review comment:
Do not create `emptyTestData` anymore as we already [created one here](https://github.com/apache/spark/blob/master/sql/core/src/test/scala/org/apache/spark/sql/test/SQLTestData.scala#L295). Create table again here will cause problem for the followed newly added test when trying to use `emptyTestData`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31873: [SPARK-34781][SQL] Eliminate LEFT SEMI/ANTI joins to its left child side in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31873:
URL: https://github.com/apache/spark/pull/31873#issuecomment-801471740
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136179/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31873: [SPARK-34781][SQL] Eliminate LEFT SEMI/ANTI joins to its left child side in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31873:
URL: https://github.com/apache/spark/pull/31873#issuecomment-801621812
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on a change in pull request #31873: [SPARK-34781][SQL] Eliminate LEFT SEMI/ANTI joins to its left child side in AQE
Posted by GitBox <gi...@apache.org>.
c21 commented on a change in pull request #31873:
URL: https://github.com/apache/spark/pull/31873#discussion_r597329797
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/EliminateUnnecessaryJoin.scala
##########
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.adaptive
+
+import org.apache.spark.sql.catalyst.planning.ExtractSingleColumnNullAwareAntiJoin
+import org.apache.spark.sql.catalyst.plans.{Inner, LeftAnti, LeftSemi}
+import org.apache.spark.sql.catalyst.plans.logical.{Join, LocalRelation, LogicalPlan}
+import org.apache.spark.sql.catalyst.rules.Rule
+import org.apache.spark.sql.execution.joins.HashedRelationWithAllNullKeys
+
+/**
+ * This optimization rule detects and eliminates unnecessary Join:
+ * 1. Join is single column NULL-aware anti join (NAAJ), and broadcasted [[HashedRelation]]
+ * is [[HashedRelationWithAllNullKeys]]. Eliminate join to an empty [[LocalRelation]].
+ *
+ * 2. Join is inner join, and either side of join is empty. Eliminate join to an empty
+ * [[LocalRelation]].
+ *
+ * 3. Join is left semi join
+ * 3.1. Join right side is empty. Eliminate join to an empty [[LocalRelation]].
+ * 3.2. Join right side is non-empty and condition is empty. Eliminate join to its left side.
+ *
+ * 4. Join is left anti join
+ * 4.1. Join right side is empty. Eliminate join to its left side.
+ * 4.2. Join right side is non-empty and condition is empty. Eliminate join to an empty
+ * [[LocalRelation]].
+ *
+ * This applies to all joins (sort merge join, shuffled hash join, broadcast hash join, and
+ * broadcast nested loop join), because sort merge join and shuffled hash join will be changed
+ * to broadcast hash join with AQE at the first place.
+ */
+object EliminateUnnecessaryJoin extends Rule[LogicalPlan] {
+
+ private def isRelationWithAllNullKeys(plan: LogicalPlan) = plan match {
+ case LogicalQueryStage(_, stage: BroadcastQueryStageExec)
+ if stage.resultOption.get().isDefined =>
+ stage.broadcast.relationFuture.get().value == HashedRelationWithAllNullKeys
+ case _ => false
+ }
+
+ private def checkRowCount(plan: LogicalPlan, hasRow: Boolean): Boolean = plan match {
Review comment:
@maropu - I thought about this too, but I think this is dangerous as we want to make sure the child output is known, and row count is larger than zero.
There can be the case where `hasNoRow()` returns false but the plan is not executed in AQE at all (not `LogicalQueryStage`) or result is not known yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31873: [SPARK-34781][SQL] Eliminate LEFT SEMI/ANTI joins to its left child side in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31873:
URL: https://github.com/apache/spark/pull/31873#issuecomment-801540306
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40765/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31873: [SPARK-34781][SQL] Eliminate LEFT SEMI/ANTI joins to its left child side in AQE
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31873:
URL: https://github.com/apache/spark/pull/31873#issuecomment-802407757
I left the single minor comment and it looks fine otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31873: [SPARK-34781][SQL] Eliminate LEFT SEMI/ANTI joins to its left child side in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31873:
URL: https://github.com/apache/spark/pull/31873#issuecomment-801491471
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40761/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31873: [SPARK-34781][SQL] Eliminate LEFT SEMI/ANTI joins to its left child side in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31873:
URL: https://github.com/apache/spark/pull/31873#issuecomment-801491471
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40761/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #31873: [SPARK-34781][SQL] Eliminate LEFT SEMI/ANTI joins to its left child side in AQE
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #31873:
URL: https://github.com/apache/spark/pull/31873#issuecomment-801604211
Closed & reopened the PR to trigger test rerun.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31873: [SPARK-34781][SQL] Eliminate LEFT SEMI/ANTI joins to its left child side in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31873:
URL: https://github.com/apache/spark/pull/31873#issuecomment-801540306
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40765/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #31873: [SPARK-34781][SQL] Eliminate LEFT SEMI/ANTI joins to its left child side in AQE
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #31873:
URL: https://github.com/apache/spark/pull/31873#issuecomment-802422571
Thank you @maropu and @cloud-fan for review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #31873: [SPARK-34781][SQL] Eliminate LEFT SEMI/ANTI joins to its left child side in AQE
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #31873:
URL: https://github.com/apache/spark/pull/31873#issuecomment-801602266
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org