[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1133: MINIFICPP-1425 upgrade compilers on linux and mac, use C++17, prepare for C++20

[GitBox <gi...@apache.org>]

szaszm commented on a change in pull request #1133:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1133#discussion_r673843086



##########
File path: arch.sh
##########
@@ -21,7 +21,8 @@ verify_enable_platform(){
     verify_gcc_enable "${feature}"
 }
 add_os_flags() {
-    CMAKE_BUILD_COMMAND="${CMAKE_BUILD_COMMAND}"
+    #CMAKE_BUILD_COMMAND="${CMAKE_BUILD_COMMAND}"

Review comment:
       I left it as a documentation of what could be changed there, but I had to comment it out, because shellcheck complained that it was a noop. Since it doesn't currently complain in the CI, I assume it might be because of a version difference between the CI and my machine. Mine is 0.7.2.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org