You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org> on 2025/10/14 20:28:48 UTC

[PR] HIVE-29264: Use metaconf prefix to honor metastore configurations for direct sql in q-files [hive]

Aggarwal-Raghav opened a new pull request, #6129:
URL: https://github.com/apache/hive/pull/6129

   ### What changes were proposed in this pull request?
   Check [HIVE-29264](https://issues.apache.org/jira/browse/HIVE-29264) for detailed explanation. Use `metaconf:metastore.try.direct.sql` instead of `hive.metastore.try.direct.sql` in q files.
   
   
   ### Why are the changes needed?
   In alter_table_column_stats.q, it is not honoring the direct sql = false configs, due to which the MetaException is not thrown for partitioned table in `itests/qtest/target/surefire-reports/org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver-output.txt `. https://github.com/apache/hive/blob/63868a945881a577790813b004aab5c3a80be575/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java#L10075
   ```
   analyze table testpart0 compute statistics for columns;
   ```
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   Local testing by running the modified q files in this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


Re: [PR] HIVE-29264: Use metaconf prefix to honor metastore configurations for direct sql in q-files [hive]

Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav commented on PR #6129:
URL: https://github.com/apache/hive/pull/6129#issuecomment-3416566731

   > Should we update `alter_rename_table.q` and `repl_4_exim_nocolstat.q`, too?
   > 
   > ```
   > % git grep 'metastore.try.direct.sql' | grep '\.q:' | grep -v 'metaconf:' 
   > ql/src/test/queries/clientpositive/alter_rename_table.q:set metastore.try.direct.sql=false;
   > ql/src/test/queries/clientpositive/alter_table_column_stats.q:-- Test for external tables with metastore.try.direct.sql.ddl as false
   > ql/src/test/queries/clientpositive/repl_4_exim_nocolstat.q:set metastore.try.direct.sql=false;
   > ql/src/test/queries/clientpositive/set_metaconf.q:set hive.metastore.try.direct.sql;
   > ql/src/test/queries/clientpositive/set_metaconf.q:set hive.metastore.try.direct.sql;
   > ```
   
   yes. thanks for pointing it out. Not changing `set_metaconf.q` as it seems to be testing whether metaconf is changing HiveConf or not.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


Re: [PR] HIVE-29264: Use metaconf prefix to honor metastore configurations for direct sql in q-files [hive]

Posted by "okumin (via GitHub)" <gi...@apache.org>.
okumin commented on PR #6129:
URL: https://github.com/apache/hive/pull/6129#issuecomment-3419169757

   @Aggarwal-Raghav Thanks for identifying and reporting the issue, and submitting the patch!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


Re: [PR] HIVE-29264: Use metaconf prefix to honor metastore configurations for direct sql in q-files [hive]

Posted by "okumin (via GitHub)" <gi...@apache.org>.
okumin merged PR #6129:
URL: https://github.com/apache/hive/pull/6129


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


Re: [PR] HIVE-29264: Use metaconf prefix to honor metastore configurations for direct sql in q-files [hive]

Posted by "okumin (via GitHub)" <gi...@apache.org>.
okumin commented on PR #6129:
URL: https://github.com/apache/hive/pull/6129#issuecomment-3414106766

   I reproduced the issue on the master branch.
   
   ```
   $ mvn clean test -Dtest=TestMiniLlapLocalCliDriver -Dqfile=alter_table_column_stats.q -Drat.skip -Pitests -pl itests/qtest 
   $ less itests/qtest/target/surefire-reports/org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver-output.txt | grep 'Jdo path is not implemented for stats aggr'
   $ 
   ```
   
   I also confirmed the expected error is thrown with this patch.
   
   ```
   $ less itests/qtest/target/surefire-reports/org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver-output.txt | grep 'Jdo path is not implemented for stats aggr'
   2025-10-16T23:37:01,164 ERROR [a423d571-12e6-473e-a852-ba9c1c947e12 main] metastore.RetryingHMSHandler: MetaException(message:Jdo path is not implemented for stats aggr.)
   2025-10-16T23:37:06,336 ERROR [a423d571-12e6-473e-a852-ba9c1c947e12 main] metastore.RetryingHMSHandler: MetaException(message:Jdo path is not implemented for stats aggr.)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


Re: [PR] HIVE-29264: Use metaconf prefix to honor metastore configurations for direct sql in q-files [hive]

Posted by "okumin (via GitHub)" <gi...@apache.org>.
okumin commented on PR #6129:
URL: https://github.com/apache/hive/pull/6129#issuecomment-3414155969

   Should we update `alter_rename_table.q` and `repl_4_exim_nocolstat.q`, too?
   
   ```
   % git grep 'metastore.try.direct.sql' | grep '\.q:' | grep -v 'metaconf:' 
   ql/src/test/queries/clientpositive/alter_rename_table.q:set metastore.try.direct.sql=false;
   ql/src/test/queries/clientpositive/alter_table_column_stats.q:-- Test for external tables with metastore.try.direct.sql.ddl as false
   ql/src/test/queries/clientpositive/repl_4_exim_nocolstat.q:set metastore.try.direct.sql=false;
   ql/src/test/queries/clientpositive/set_metaconf.q:set hive.metastore.try.direct.sql;
   ql/src/test/queries/clientpositive/set_metaconf.q:set hive.metastore.try.direct.sql;
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


Re: [PR] HIVE-29264: Use metaconf prefix to honor metastore configurations for direct sql in q-files [hive]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #6129:
URL: https://github.com/apache/hive/pull/6129#issuecomment-3416838235

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6129) **Quality Gate passed**  
   Issues  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6129&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6129&issueStatuses=ACCEPTED)
   
   Measures  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=6129&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6129&metric=new_coverage&view=list)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6129&metric=new_duplicated_lines_density&view=list)  
     
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6129)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


Re: [PR] HIVE-29264: Use metaconf prefix to honor metastore configurations for direct sql in q-files [hive]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #6129:
URL: https://github.com/apache/hive/pull/6129#issuecomment-3403760163

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6129) **Quality Gate passed**  
   Issues  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6129&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6129&issueStatuses=ACCEPTED)
   
   Measures  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=6129&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6129&metric=new_coverage&view=list)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6129&metric=new_duplicated_lines_density&view=list)  
     
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6129)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org