[GitHub] [arrow-rs] alamb commented on a diff in pull request #4048: Add offsets accessors to variable length arrays (#3879)

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #4048:
URL: https://github.com/apache/arrow-rs/pull/4048#discussion_r1162717784


##########
arrow-array/src/array/byte_array.rs:
##########
@@ -67,6 +67,18 @@ impl<T: ByteArrayType> GenericByteArray<T> {
         offsets[i + 1] - offsets[i]
     }
 
+    /// Returns a reference to the offsets of this array

Review Comment:
   I think it might help to note in the docstrings:
   1. How this is different than `value_offsets` (other than the signature)
   2. Which is preferred (it sounds from this PR's description that `offsets` is preferred, but that is not obvious from the code as it is written)
   
   The same applies to `values` and `value_data`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org