You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/05/11 07:27:08 UTC

[GitHub] [pulsar] freeznet opened a new pull request #10538: [fix #9640] remove `pulsar-client-admin-api` dependency : `pulsar-package-core`

freeznet opened a new pull request #10538:
URL: https://github.com/apache/pulsar/pull/10538


   Fixes #9640
   Part 2
   
   ### Motivation
   
   Module `pulsar-client-admin-api` has been introduced in #9246, but it pulling in many dependencies.  That is undesirable for an "API" module. 
   
   This PR removes `pulsar-package-core` from the dependency, and resolves the issues. Later there will be sepreate PRs to remove other dependencies like `pulsar-common`.
   
   #10513 removes `pulsar-client-original`.
   
   ### Modifications
   
   remove `pulsar-package-core` from `pulsar-client-admin-api`.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] freeznet commented on pull request #10538: [fix #9640] remove `pulsar-client-admin-api` dependency : `pulsar-package-core`

Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #10538:
URL: https://github.com/apache/pulsar/pull/10538#issuecomment-838127769


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat merged pull request #10538: [fix #9640] remove `pulsar-client-admin-api` dependency : `pulsar-package-core`

Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #10538:
URL: https://github.com/apache/pulsar/pull/10538


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] freeznet edited a comment on pull request #10538: [fix #9640] remove `pulsar-client-admin-api` dependency : `pulsar-package-core`

Posted by GitBox <gi...@apache.org>.
freeznet edited a comment on pull request #10538:
URL: https://github.com/apache/pulsar/pull/10538#issuecomment-838349270


   @sijie @merlimat @jerrypeng @zymap @lhotari please help to review this PR if you have time, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] freeznet commented on pull request #10538: [fix #9640] remove `pulsar-client-admin-api` dependency : `pulsar-package-core`

Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #10538:
URL: https://github.com/apache/pulsar/pull/10538#issuecomment-838349270


   @sijie @merlimat @jerrypeng @zymap please help to review this PR if you have time, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org