You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/06/06 03:16:43 UTC

[GitHub] [spark] LuciferYang commented on pull request #36732: [SPARK-39345][CORE][SQL][DSTREAM][ML][MESOS][SS] Replace `filter(!condition)` with `filterNot(condition)`

LuciferYang commented on PR #36732:
URL: https://github.com/apache/spark/pull/36732#issuecomment-1146991307

   > The change is OK; I don't think it adds any performance. The only hesitation here would be code churn and possible merge conflicts due to this. I'm kind of neutral on it, I think it's OK.
   
   If this acceptable, I can give pr for 3.3, 3.2 and 3.1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org