You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/11/30 15:07:19 UTC
[GitHub] [tvm] Lunderberg opened a new pull request, #13524: [TIR] Disable RewriteSimplifier extensions in RemoveNoOp
Lunderberg opened a new pull request, #13524:
URL: https://github.com/apache/tvm/pull/13524
During a `tir.Simplify` pass, these extensions were conditionally enabled based on the `PassContext`. Prior to this commit, they were enabled by default in the `tir.RemoveNoOp` pass, as the simplified expressions were only used to prove/disprove a no-op, and did not appear in the output TIR. However, this caused performance issues for some nested boolean expressions.
This PR disables the analyzer extensions for the analyzer used by `tir.RemoveNoOp`. The extensions are still used internally by `ControlFlowGraph`, including during the data-flow analysis used if `tir.transform.RemoveNoOpConfig.use_dataflow_analysis` is enabled, so the opt-in data-dependent no-op removals are unaffected.
Related to issue #13508.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #13524: [TIR] Disable RewriteSimplifier extensions in RemoveNoOp
Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13524:
URL: https://github.com/apache/tvm/pull/13524#issuecomment-1332311698
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* cc @Hzfengsy, @junrushao <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vinx13 merged pull request #13524: [TIR] Disable RewriteSimplifier extensions in RemoveNoOp
Posted by GitBox <gi...@apache.org>.
vinx13 merged PR #13524:
URL: https://github.com/apache/tvm/pull/13524
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org